Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Dec 2020 14:40:09 +0100
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org
Subject: Re: [PATCH v3 net-next 2/2] net: dsa: qca: ar9331: export stats64
Message-ID: <20201204134009.q6alw6t2pk22saak@pengutronix.de>
References: <20201202140904.24748-1-o.rempel@pengutronix.de>
 <20201202140904.24748-3-o.rempel@pengutronix.de>
 <20201202104207.697cfdbb@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
 <20201203085011.GA3606@pengutronix.de>
 <20201203083517.3b616782@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
 <20201203175320.f3fmyaqoxifydwzv@pengutronix.de>
 <20201203180140.4puwxgailw2iysxz@skbuf>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201203180140.4puwxgailw2iysxz@skbuf>
User-Agent: NeoMutt/20170113 (1.7.2)
Precedence: bulk

On Thu, Dec 03, 2020 at 08:01:40PM +0200, Vladimir Oltean wrote:
> On Thu, Dec 03, 2020 at 06:53:20PM +0100, Oleksij Rempel wrote:
> > It is possible to poll it more frequently, but  it make no reals sense
> > on this low power devices.
> 
> Frankly I thought you understood the implications of periodic polling
> and you're ok with them,

I added polling to read out small counters to avoid overflow.

> just wanting to have _something_.

Having something is good, but making it good is better :D

> But fine,
> welcome to my world, happy to have you onboard...
> 
> > What kind of options do we have?
> 
> https://www.spinics.net/lists/netdev/msg703774.html
> https://www.spinics.net/lists/netdev/msg704370.html
> 
> Unfortunately I've been absolutely snowed under with work lately. I hope
> to be able to come back to that during the weekend or something like that.

Ok, so the strategy is to fix the original issue. Sound good.

For now I'll resend this patches without accessing mdio regs from the
stats64 callback. It will give initial play ground, so we can see what
else should be done for DSA specific use case.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |