Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <3548618a-eb36-bf3a-d589-e06fd5f2111b@kernel.org>
In-Reply-To: <3548618a-eb36-bf3a-d589-e06fd5f2111b@kernel.org>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Fri, 4 Dec 2020 16:33:23 +0100
Message-ID: <CAJKOXPcaUx5JwVU+VtkJWimTn2LgY5bbBPn3vJLP22oHQiU48g@mail.gmail.com>
Subject: Re: [PATCH] [v2] clk: samsung: mark PM functions as __maybe_unused
To:     Sylwester Nawrocki <snawrocki@kernel.org>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 4 Dec 2020 at 16:28, Sylwester Nawrocki <snawrocki@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The use of SIMPLE_DEV_PM_OPS() means that the suspend/resume
> functions are now unused when CONFIG_PM is disabled:
>
> drivers/clk/samsung/clk-exynos-clkout.c:219:12: error:
> 'exynos_clkout_resume' defined but not used [-Werror=unused-function]
>    219 | static int exynos_clkout_resume(struct device *dev)
>        |            ^~~~~~~~~~~~~~~~~~~~
> drivers/clk/samsung/clk-exynos-clkout.c:210:12: error:
> 'exynos_clkout_suspend' defined but not used [-Werror=unused-function]
>    210 | static int exynos_clkout_suspend(struct device *dev)
>        |            ^~~~~~~~~~~~~~~~~~~~~
>
> Mark them as __maybe_unused to shut up the otherwise harmless warning.
>
> Fixes: 9484f2cb8332 ("clk: samsung: exynos-clkout: convert to module
> driver")
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: add proper changelog text
>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Indeed this should go via samsung soc tree...

Best regards,
Krzysztof