Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp524027pxu; Fri, 4 Dec 2020 08:54:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTibgPxRTSj9GlMKd1Z/3uXIhkFmpf+kXOSqmf+dt8nZiQGYn55YU4vNYuJr68JkrjhmyO X-Received: by 2002:a50:fc96:: with SMTP id f22mr8803485edq.162.1607100844572; Fri, 04 Dec 2020 08:54:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607100844; cv=none; d=google.com; s=arc-20160816; b=0Cno06A+yXH7ahRgNS4uXk6p1p2lahi9pfQ0CXwlF0geWGScWflY01HppJoJg/85q5 gCQjCq8WyygCQNWNriOyilPkwOcMO0LEEoagXfdAfCsxJnj5mMe/SeYEG09jhS44zyr/ FLjNXS9GDS9BOJBOagwsAWUYzTdUt3SZrmoqG6hYuA3PytG6C+XNePi1baLP9B124Rlg f9n2ecM71fAWdjcWJJmRJeOf+6k60gbNPopW7IAZJLqye8a7H/zrw0NXW8IXUsFSoIVy ICFlGFSMXwI5+DFbLIVgjolPH7bn3LO8NytJF27felcj9a5B2+WDm3jWOwIuXESJ8/SU p+3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :dkim-signature:from; bh=fVEfPPD9NE4f5E+YaRSwLsnYrJkOxX3+vwZtkdse0DI=; b=wWHsRhnRQTcuKdTfOMzTJQAgvFqGJM3xM6rWRPdl5kmAUUsXJ4mSJ6QEQNxPu4s2/R 9gsiM4OQa0vc4M1lz0Yh5aadtC0oT1K0jjC7fwiBqt1QVTCDL6ALjcK58F6Tkwu0yxOC dCeLptRIwbl+b1UzOnbSD7vvvOa1NHL8aFor+WZEJUZH1Ykxy5+uBEKV/15ONS0UIwiS raWsbqosnYytiS5bdlAr2yq3xQZssng8PXRTaphM3AoFaKbWl4/+B8G/69MOVxRloup6 vfDJobBmbhKfh/1v6lRspd05vIu4J26gXl9IjK8OK57x1mHn42Px2sFxjWOB6H1UBu8B wMBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JU0l8O7v; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=ONHXERhP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a16si3389612edn.109.2020.12.04.08.53.40; Fri, 04 Dec 2020 08:54:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JU0l8O7v; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=ONHXERhP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387869AbgLDQtn (ORCPT + 99 others); Fri, 4 Dec 2020 11:49:43 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:48542 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731057AbgLDQtn (ORCPT ); Fri, 4 Dec 2020 11:49:43 -0500 From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1607100541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fVEfPPD9NE4f5E+YaRSwLsnYrJkOxX3+vwZtkdse0DI=; b=JU0l8O7vyRyZKX7y6MQY/xAfWPlmC+uQ+iEYXqBDcjbT20ERSvcaaNMb7T02B1TGWfc2In vl0pYoJEAEfV5B4wT8sXUd+bitffRWK4V6Qp1o+ZhyPnzqpwXbKicBPRcxqQD6d43x2phX Y7BwLMvfG8pRVVnaojx0BrxFqp3NUQZRAeFl2o576Nv6T9sMOJVS72YZTg3X61CfUeGrlI 2qknB+gWh54xdxbZMxUGYpFWGURTcrkxtwkVckH+XgUzqaMXXxpfY75LDZK1yeLsOgV8lK mzTqFWBVXsfN8Htm53YuQ4MDPv6gTfLP+jphy0E3ldmBCq5THtWMk53ozSUr2w== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1607100541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fVEfPPD9NE4f5E+YaRSwLsnYrJkOxX3+vwZtkdse0DI=; b=ONHXERhPkRLPUfPSM7oeLR+/Sh5Zvi/X0sl348EPxAQa2NjgrkzrFfT8x8temtczhdShRT 6r4Bkd+/qyXqyBDA== To: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" , "Ahmed S . Darwish" , Thomas Gleixner , Sebastian Andrzej Siewior Subject: [PATCH 2/3] sr: Switch the sector size back to 2048 if sr_read_sector() changed it. Date: Fri, 4 Dec 2020 17:48:49 +0100 Message-Id: <20201204164850.2343359-2-bigeasy@linutronix.de> In-Reply-To: <20201204164850.2343359-1-bigeasy@linutronix.de> References: <20201204164803.ovwurzs3257em2rp@linutronix.de> <20201204164850.2343359-1-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sr_read_sector() is hardly used since v2.3.16. Its only purpose is to check if it is a XA medium via sr_is_xa(). This check is only enabled if the module parameter `xa_test' is enabled. Change the sector size back to 2048 if it was changed. With this change, there is no lazy sector size changing left. Signed-off-by: Sebastian Andrzej Siewior --- drivers/scsi/sr_ioctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/sr_ioctl.c b/drivers/scsi/sr_ioctl.c index ffcf902da3901..5703f8400b73c 100644 --- a/drivers/scsi/sr_ioctl.c +++ b/drivers/scsi/sr_ioctl.c @@ -549,6 +549,8 @@ static int sr_read_sector(Scsi_CD *cd, int lba, int blk= size, unsigned char *dest cgc.timeout =3D IOCTL_TIMEOUT; rc =3D sr_do_ioctl(cd, &cgc); =20 + if (blksize !=3D CD_FRAMESIZE) + rc |=3D sr_set_blocklength(cd, CD_FRAMESIZE); return rc; } =20 --=20 2.29.2