Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp590166pxu; Fri, 4 Dec 2020 10:23:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQZ3+cusD3FHLPBE6MP4MIkWZ7S0P/NCwfR9XTR2OgNHJ/FJqSKnujN4J/h5zIyunxvO0A X-Received: by 2002:a17:906:caa:: with SMTP id k10mr8137556ejh.204.1607106198706; Fri, 04 Dec 2020 10:23:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607106198; cv=none; d=google.com; s=arc-20160816; b=vFG6hLSv5yym7b7eKEkr3xMyTI0NMyoaDUAlKpR7kl8THpPkh3bW9Z8OXLYmwg3iCt shNnMCf5X3f+3ug16kMwMytDOo/OQgPengakzGzWj5kuWddo0eFHCg4h/tSaRw5Wr4Fg 97ZAHQr/WJxxDB1l908nG9KDOZl2Kiy1KNuBXarLlo7VDbAYT29eZtb8JanxdirsuBQY 9h7RxKhI2BhfGYBwkxxLyohsuy7+IMSxLb2+xWVWu7k7S7LnhgImzOiuSisobLblOS5p EFRfkcWJXkPNC2RrrnBu+1TxIekm9xHJI9Z8zYSgK7fo73R1ctTNe4mIZf6RQkg22Ys6 IXPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Nlb27gOIz2SmsAyu6K72xtrnZxBbjqGUhaedoDoNJ5U=; b=zSvHrAvt4i7tDw6E5qK3/SQFxqlEtW7WuQtCINVed/I2tHg/3MOeMmCLCM0xJdRu6Z RrGztVxxRJIDum2cYNE+N46X3HwAsM96nFoYBXhtU3RHbji2hrNLGEfhIUiCCgrJ62xT +TyNrjKMTYZRu8u6JtSpEvQViwaw4r0Ld7kLwpwInueeVZZ2PfCjHLujW5NhryWR1IMT 7kZBxtBZSNCoHgO6X6dQgOJXlM3QFvBEgYYqGFqxybebLLuhsHyXXZTUhWN7Rol1CPT4 1DiFjRdShZNpMMGwCQuF4zCAlD6fpZdK8LRnA2AdLjN9DxmMw9rONdU4q6w6iRO69l5x So8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=v81Nqn1Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u9si3206158edd.596.2020.12.04.10.22.53; Fri, 04 Dec 2020 10:23:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=v81Nqn1Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728001AbgLDSS6 (ORCPT + 99 others); Fri, 4 Dec 2020 13:18:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726021AbgLDSS5 (ORCPT ); Fri, 4 Dec 2020 13:18:57 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 947FAC0613D1; Fri, 4 Dec 2020 10:18:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Nlb27gOIz2SmsAyu6K72xtrnZxBbjqGUhaedoDoNJ5U=; b=v81Nqn1QAIeCQWqVcMHNHb8ovS aCoM6YQ27ZI+zBYptGpbs7neLx847cQHyVkFNnKfjhuTbY6bhypvfgrFlgKoT2qLLK1sbKqwVwvzd WndUrufh1oGnrjOXDlD337yx9os+D61CZp1GEkPX5eQNmBB81IpDGe6bIjGDowzD2ZCsD3aKrCQC9 48WDG979Fw1IlzLDIYebxAwT8UL8259V7Nsmcuo6mbcysuqFp9/5LRk0N7XRbpgkjrXSaluSiOe1W KUvnZ7nOjPcbkLq9bxC1Cpi7NqZMVOUCRDy2qE3t9P7k8ufpzpsJAnh44FEPOAWIprwvGF6KLh/Ul VHLDxenw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1klFej-0006v1-1b; Fri, 04 Dec 2020 18:18:09 +0000 Date: Fri, 4 Dec 2020 18:18:08 +0000 From: Christoph Hellwig To: Will McVicker Cc: Christoph Hellwig , Jessica Yu , Masahiro Yamada , Michal Marek , Greg Kroah-Hartman , Saravana Kannan , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 0/2] Adds support to capture module's SCM version Message-ID: <20201204181808.GA26478@infradead.org> References: <20201125010541.309848-1-willmcvicker@google.com> <20201204075159.GA29752@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 04, 2020 at 10:13:56AM -0800, Will McVicker wrote: > On Fri, Dec 04, 2020 at 07:51:59AM +0000, Christoph Hellwig wrote: > > I think your decription still shows absolutely no benefit for the > > kernel, so I'not sure why anyone would want to waste time on this. > Hi Christoph, > > Did you get a chance to read my earlier responses regarding the uses for > in-tree modules? > > The biggest benefit for the upstream community is being about to get the SCM > version for *any* module (including in-tree modules) in the initramfs via the > sysfs node. Currently there is no way to do that and there is no guarantee that That assumes the SCM version of a module has any kind of meaning for an in-tree module. Which it doesn't. If you care about the SCM version of an in-tree module the only thing we need is one single global sysfs file.