Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432AbWH3Tst (ORCPT ); Wed, 30 Aug 2006 15:48:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751434AbWH3Tst (ORCPT ); Wed, 30 Aug 2006 15:48:49 -0400 Received: from smtp.osdl.org ([65.172.181.4]:53671 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751432AbWH3Tss (ORCPT ); Wed, 30 Aug 2006 15:48:48 -0400 Date: Wed, 30 Aug 2006 12:47:52 -0700 From: Andrew Morton To: sekharan@us.ibm.com Cc: Kirill Korotaev , Rik van Riel , CKRM-Tech , Linux Kernel Mailing List , Andi Kleen , Christoph Hellwig , Andrey Savochkin , Alan Cox , Matt Helsley , Alexey Dobriyan , Oleg Nesterov , devel@openvz.org, Pavel Emelianov Subject: Re: [ckrm-tech] [PATCH 3/7] BC: beancounters core (API) Message-Id: <20060830124752.8400c49e.akpm@osdl.org> In-Reply-To: <1156964314.12403.31.camel@linuxchandra> References: <44F45045.70402@sw.ru> <44F454D9.7060203@sw.ru> <1156964314.12403.31.camel@linuxchandra> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 706 Lines: 17 On Wed, 30 Aug 2006 11:58:34 -0700 Chandra Seetharaman wrote: > > +void bc_uncharge_locked(struct beancounter *bc, int res, unsigned long val); > > +void bc_uncharge(struct beancounter *bc, int res, unsigned long val); > > + > > +struct beancounter *beancounter_findcreate(bcid_t id, int mask); > > prototype do not need the parameter names, types would suffice (would > save you few characters). argh. Those few characters are useful. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/