Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Dec 2020 14:08:04 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
CC:     Muchun Song <songmuchun@bytedance.com>, <mhocko@kernel.org>,
        <vdavydov.dev@gmail.com>, <akpm@linux-foundation.org>,
        <cgroups@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mm/memcontrol: make the slab calculation consistent
Message-ID: <20201204220804.GA1772002@carbon.DHCP.thefacebook.com>
References: <20201203031111.3187-1-songmuchun@bytedance.com>
 <20201204154613.GA176901@cmpxchg.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201204154613.GA176901@cmpxchg.org>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.DHCP.thefacebook.com (2620:10d:c090:400::5:6638) by MWHPR2201CA0039.namprd22.prod.outlook.com (2603:10b6:301:16::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.17 via Frontend Transport; Fri, 4 Dec 2020 22:08:08 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a1108504-5263-44ef-b320-08d898a115b4
X-MS-TrafficTypeDiagnostic: BYAPR15MB2630:
X-Microsoft-Antispam-PRVS: <BYAPR15MB2630A546614C8F5D7AEDAFC9BEF10@BYAPR15MB2630.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6A+JxtMd1n3uY/LxgMI+71EryKuVQfz5qxvX/gACVNafQSGu+O2LDttTdZvJ+D284UWaC/RryLbKpZVpKb/j5nVMM8Ed9cmtTm/JpXQCNIfAbloAXRWkzAO3Vo+m5Ou3863GRGkX9HkJlaPE5E6Qw0DJxJt4kf/E5NioeVihLCdWYhKAXeLxb4WVgh8T5HJQhI7ZJepj0Bzm1iNuxQMz9Q5RlQnW2Y/1X1pC4Z+Yruggr146krMxxq4AYMoQuztGHuAUaGblWJ1S/6I2MbtaWixZJmGQXEpFSXjLTZ2KzQpL0HG3ahHsLJY5RWfQN1AYbW2dzDjjJPriAQlW5yaMFg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(136003)(366004)(396003)(39860400002)(376002)(52116002)(6506007)(16526019)(4326008)(6916009)(7696005)(2906002)(5660300002)(9686003)(478600001)(1076003)(316002)(55016002)(6666004)(8936002)(66946007)(83380400001)(186003)(66556008)(86362001)(8676002)(66476007)(33656002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?xf/9e1ksZ3w2qlZdgGdnbxgdApNPhmmceF6xgiWK6rrL2n8ikvhprqFGlgFr?=
 =?us-ascii?Q?m/BriXWdUIfoFRsT9HoK3c7LkMAZL6SMUZbfjNr8GKf5WYQrX8872irW6yWi?=
 =?us-ascii?Q?qohUriQLhl200prvaIB/TWW5GD7SVdYuREkFlH2Ozm/o2MHIxDOP3vU1Hkmh?=
 =?us-ascii?Q?dbGJWpPC4nIawzAuiNIBbwypyIsBz6P/RB+BcU2/tzarhejLSZQ13ViLKGyy?=
 =?us-ascii?Q?QNef51xKTz4jEoDNwm7iEF9BGW6RuZ7UZJIC2WM8bW2BJX8me3JoDh/74ACl?=
 =?us-ascii?Q?62smUWhLeDuRn1dINWbqcbW1pE0ASxxcYlrLivd/zd7PdbyNDAYy5eIyGbMA?=
 =?us-ascii?Q?HcxvXC9wNkQYnSHJnFoBFUKlzd5qv3L40+mLhI+QvPodfQHRjKAcss34fNby?=
 =?us-ascii?Q?BWBHpi3r2GQorofxqY9ew7OmqQ465vzva9Eow7OlHzYQvRMoFAy/JXeyXc0F?=
 =?us-ascii?Q?RNdx7ilTJMZngxecmr57Jmg1XODJ8kGo6yKLau4WfNvZ8n6x21tYchhFOjKg?=
 =?us-ascii?Q?eW4Ak0zZ8YxvgPtASIHOcja0vDu9A2JPgwee634kLQgad9+r12S8OtiD4zXo?=
 =?us-ascii?Q?b1t5CPIKDlPJKeh6pHUo3NtFTiIj7uas7vr7Nc+FDUeWnFuM+hQVEC+clPw0?=
 =?us-ascii?Q?39svFjfVqJRsskTT3Sh1/SuQjLHFfx5qVxZW3ZtbJ2lViz+3wQFL5bz7n0Pq?=
 =?us-ascii?Q?azpM+HPpkM8yWBOHLDc8BvbIj8MIiBoZkezt+3G2jPwSgjt8qamgbXTpenZ+?=
 =?us-ascii?Q?LsOdFdHFrRiR3M0azIxQ20AhM7AYk/SdhTiMR7dhsibdWy0nVK+Fht2ymeQr?=
 =?us-ascii?Q?O6OlG8+jfZvMJ4jcDqtaMdUNhSUaoLTURlbN0GlC10dLBNZstJr6cWjN5KJ7?=
 =?us-ascii?Q?43xx394XH981mH6MPx5+g0kV8W9BBf5Eg/Jct9578uEEmJmDcp+7PDn0pkE8?=
 =?us-ascii?Q?u5aAocIU8rIF/xdsZBiCzr/kNGXvTcxE+0clC1id/IL1iSa9tDmf5KAtwIFo?=
 =?us-ascii?Q?ccZ5ywmA2RcVNflhN8gX2tSQfA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a1108504-5263-44ef-b320-08d898a115b4
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2020 22:08:09.6834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bmnu1OFZmwHSEF49aEi9Ejfxtf0vi2iP90kTtVv6WVbxnTxnwU/feorQb80WAiwj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2630
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-12-04_12:2020-12-04,2020-12-04 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501
 clxscore=1015 bulkscore=0 malwarescore=0 phishscore=0 mlxscore=0
 suspectscore=1 mlxlogscore=999 impostorscore=0 spamscore=0 adultscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2012040124
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 04, 2020 at 10:46:13AM -0500, Johannes Weiner wrote:
> On Thu, Dec 03, 2020 at 11:11:11AM +0800, Muchun Song wrote:
> > Although the ratio of the slab is one, we also should read the ratio
> > from the related memory_stats instead of hard-coding. And the local
> > variable of size is already the value of slab_unreclaimable. So we
> > do not need to read again. Simplify the code here.
> > 
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> > Acked-by: Roman Gushchin <guro@fb.com>
> 
> I agree that ignoring the ratio right now is not very pretty, but
> 
> 		size = memcg_page_state(memcg, NR_SLAB_RECLAIMABLE_B) +
> 		       memcg_page_state(memcg, NR_SLAB_UNRECLAIMABLE_B);
> 		seq_buf_printf(&s, "slab %llu\n", size);
> 
> is way easier to understand and more robust than using idx and idx + 1
> and then requiring a series of BUG_ONs to ensure these two items are
> actually adjacent and in the right order.
> 
> There is a redundant call to memcg_page_state(), granted, but that
> function is extremely cheap compared with e.g. seq_buf_printf().
> 
> >  mm/memcontrol.c | 26 +++++++++++++++++++++-----
> >  1 file changed, 21 insertions(+), 5 deletions(-)
> 
> IMO this really just complicates the code with little discernible
> upside. It's going to be a NAK from me, unfortunately.
> 
> 
> In retrospect, I think that memory_stats[] table was a mistake. It
> would probably be easier to implement this using a wrapper for
> memcg_page_state() that has a big switch() for unit
> conversion. Something like this:

+1

> 
> /* Translate stat items to the correct unit for memory.stat output */
> static unsigned long memcg_page_state_output(memcg, item)
> {
> 	unsigned long value = memcg_page_state(memcg, item);
> 	int unit = PAGE_SIZE;
> 
> 	switch (item) {
> 	case NR_SLAB_RECLAIMABLE_B:
> 	case NR_SLAB_UNRECLAIMABLE_B:
> 	case WORKINGSET_REFAULT_ANON:
> 	case WORKINGSET_REFAULT_FILE:
> 	case WORKINGSET_ACTIVATE_ANON:
> 	case WORKINGSET_ACTIVATE_FILE:
> 	case WORKINGSET_RESTORE_ANON:
> 	case WORKINGSET_RESTORE_FILE:
> 	case MEMCG_PERCPU_B:
> 		unit = 1;
> 		break;
> 	case NR_SHMEM_THPS:
> 	case NR_FILE_THPS:
> 	case NR_ANON_THPS:
> 		unit = HPAGE_PMD_SIZE;
> 		break;
             ^^^^^^^^^^^^
These can be easily converted to ordinary pages,
so we can completely avoid this exception.

> 	case NR_KERNEL_STACK_KB:
> 		unit = 1024;
> 		break;
> 	}

And NR_KERNEL_STACK_KB can be converted to bytes.

Then we'll have everything kernel-related in bytes and
everything userspace-related in PAGE_SIZE's.

> 	
> 	return value * unit;
> }
> 
> This would fix the ratio inconsistency, get rid of the awkward mix of
> static and runtime initialization of the table, is probably about the
> same amount of code, but simpler and more obvious overall.

+1