Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp778064pxu;
        Fri, 4 Dec 2020 15:45:14 -0800 (PST)
X-Google-Smtp-Source: ABdhPJy8xszmZPz5GtfoRyiEUuYVsNApTPnpft5OnToqDveRI+QuIp9xMco5DEnEYSV5D8EvvmRf
X-Received: by 2002:a17:906:b309:: with SMTP id n9mr9429257ejz.365.1607125514675;
        Fri, 04 Dec 2020 15:45:14 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1607125514; cv=none;
        d=google.com; s=arc-20160816;
        b=uQ1l2UqpyQL7uG5eRFlBbZa5HUjtA3rt2D22iBrdcdhQA0f8o3woNld8GHfHf69iDs
         +m3KM16FLlUEB/lIIx9nZNW9VYFADQXBzRazkb0GB8ZZIV3J2b82AqKF8U/Y3nHt04PH
         Sf0DMyUEvLF87k53gpxvPdb7rUk74nWlmwBaFf3MGEdxGDg7qbsiVLd6qhH2tQQK96dA
         r2tiiF4LYo6nhC+l4yQvNpAnY0jibKjH0Agae06B8cZbiIDpngWOI2UYNYzttvM++fIJ
         ZQaWIZYa4wX2Vb6PFFCN8y1WZILnByVY7eASPc6zDD4SfOVTtudCu1ZESjm1LDKMc4p0
         8B6A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature
         :date;
        bh=JQFzj1dLpoFdkBx0BbKyrmmbEIcWyI4nUfqzJF6kVLs=;
        b=v6M9PrC+214MMR+P/b2tIO7iBNXyJMUMR+SY88jAGevfwUKduSm2X5e3Jy42ylIgWZ
         YzMKhls1HyOGAm77Jakat3UmpcV9prbkHHYcXdE6LbN1M+otwAh6b2bIbCfEMMymgS2q
         HH8/35M9iQ/xjODoUZwXnq5jmqLtgihBW7uEP1D/5EJeJFruvYLzdW6/Twy1YWUqM5LB
         LAQJ257GAvW8Xodgo4rAQUEaxc94ALX4CKIHjhABKxqCwVEt7KXrpKE7RniD/tSL+V4s
         PnzyUUELRCEKFJyKk/soFQ5M6iO/p3pPFk7tpjAa28bJQWZOFzjmvD2P1xOrHmnmZeRK
         YxHg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Wb/HNogb";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id h14si1366410ejx.420.2020.12.04.15.44.50;
        Fri, 04 Dec 2020 15:45:14 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b="Wb/HNogb";
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727078AbgLDXlN (ORCPT <rfc822;xuhaitao4154@gmail.com>
        + 99 others); Fri, 4 Dec 2020 18:41:13 -0500
Received: from mail.kernel.org ([198.145.29.99]:43736 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726111AbgLDXlN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 4 Dec 2020 18:41:13 -0500
Date:   Fri, 4 Dec 2020 15:40:45 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1607125247;
        bh=xZueu0qpXLhKBBWVHRjSbGglwsp20+CKOkl1Y8XBxtY=;
        h=From:To:Cc:Subject:In-Reply-To:References:From;
        b=Wb/HNogbdneGDmIK4YfiQbshWHpysKiITzWmsUoMOXX5NdbH6PPtqtRjhhGRy/1jL
         5C+Lr/cVb6jWLqxNMg7PXFmThhm8gSvfIE0Lru3dlP1QKCodxd8opzoX1hxzcR7x0l
         0INsOWVngj/XrN2Xkh2r0dkUDSrhYcEJpvEKEOqfoWfVLHmu76pJAPYJvTnpenZI83
         325YKPRp6x5DqdCAbBgIXfdFYSVST3KbnJMGEu1al3ybKH8UhLZmwBcS1ps1ZOlTVF
         2W5t7shoZOZWEqP3HlmT9fPBYzTadOQKfxBgKbAHtJdn96u9pVmAlqeiF8u1KMJZuq
         GkbefH/8r1sHw==
From:   Jakub Kicinski <kuba@kernel.org>
To:     David Ahern <dsahern@gmail.com>,
        Zhang Changzhong <zhangchangzhong@huawei.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ipv4: fix error return code in rtm_to_fib_config()
Message-ID: <20201204154045.0f93f240@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
In-Reply-To: <d525d028-582d-2cea-5507-db43ee9f9fe3@gmail.com>
References: <1607071695-33740-1-git-send-email-zhangchangzhong@huawei.com>
        <d525d028-582d-2cea-5507-db43ee9f9fe3@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 4 Dec 2020 09:04:08 -0700 David Ahern wrote:
> On 12/4/20 1:48 AM, Zhang Changzhong wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> > 
> > Fixes: d15662682db2 ("ipv4: Allow ipv6 gateway with ipv4 routes")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> 
> Reviewed-by: David Ahern <dsahern@kernel.org>

Applied, thanks!