Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp779169pxu;
        Fri, 4 Dec 2020 15:47:31 -0800 (PST)
X-Google-Smtp-Source: ABdhPJyma62nMzjufdfiaIvdbfGhm/yX/bSk164dWDa5kZiLmifsaRIH1jv4lecYtlWARwBb4F7n
X-Received: by 2002:a17:906:b7d6:: with SMTP id fy22mr9449207ejb.219.1607125651244;
        Fri, 04 Dec 2020 15:47:31 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1607125651; cv=none;
        d=google.com; s=arc-20160816;
        b=zBCA48JecTI3Xz76iIq+CXXPrarfMixQBz0kXu5GjUoNU0x4egdkcbGbCkY3uZG1eX
         cqmdKCviNifITq06EwF2OqQXl2py0PepV4fj5mH4b+mEZIEaNhEeKtBvX9O4PNpizUsn
         mPSmjQkFRvJ1eq9MmozJKlKAwc2T7hWVpWHoxZJs0pPSeAOaSUgxZPqqQGJWDmaVW6Sf
         WNOvJO4/Hw8Qs8tWUw6ZNZ1hFw10ipP2tmJewLd7514Lu0MtVAL1qB2qqvl5mPQcdEa2
         GITVRsJ/clQp+y7PnUX/HlwNeae1f/FH1WgHvOZb2U1ozroHaQDKQJc+OKo0cJem778W
         x6IA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature
         :date;
        bh=dEjwYM4nI/sebtSc+ZxJK77khrDARCKsbwakqpF88Vk=;
        b=oqk97m6btQEf9jTNGx/5euAj3YzvowHN70Nglpdm0JjAzztUaQCi91XhNV6wE9RQTY
         UatgzKvztwfEEiQ4XmhVM7oaE0Z9uHT+TZj8dfozwZfAd6c5DSVPDOAntwjDts/0Br1W
         dQujeh2W/azIi2ZkYwsuJ3T4b5ajqABIWiZ+Dh/mZk8ROPdrwi6qnTb7bychY+fedpgU
         mbG2g1BZtbltwJhieqjHet2MDZ78hbOBpKZ44tVVmYky3X7YW3f26uDHnCFcO54giHG4
         oxrjsnvd146kjinhFG941izcWK8GHK85aOmfuGvCSuBiXurRO23RdpgfJuWfFl9nBZkg
         fFNQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GwPqyGNU;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id e16si2330217ejd.747.2020.12.04.15.47.08;
        Fri, 04 Dec 2020 15:47:31 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GwPqyGNU;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729046AbgLDXnV (ORCPT <rfc822;xuhaitao4154@gmail.com>
        + 99 others); Fri, 4 Dec 2020 18:43:21 -0500
Received: from mail.kernel.org ([198.145.29.99]:43884 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725847AbgLDXnV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 4 Dec 2020 18:43:21 -0500
Date:   Fri, 4 Dec 2020 15:42:54 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1607125375;
        bh=kHIX3SVj27Xyd32M1QCHO0JnCHUvF3gIbg+Db/cJgLA=;
        h=From:To:Cc:Subject:In-Reply-To:References:From;
        b=GwPqyGNU+1SRxr2TJNXI8+TvzY9iDHRwVUryjpOmPSluCzTOMfcaYUWzzhW1oAPAx
         sinx3VpmeSWGLIckCRMvlkEGamsbgXwbw5uJSgH5UHE9hLg0zCiBgecR6cXn3Rhdt/
         vhxv/XyKcz6qC9KtGqlVVPNsSgD5LwS74MD5N91moaiNqvnmeoSouLOs6g+eP2pH9l
         UG+GUYUeaTpDLESB7fvm/7GOlXlyfcBR+AOoElMHKnC26qV99UxgLZlY7y6pLPqb12
         3FRZWjjwOiGyX9eqfWX8r7Gg4KaG/WDX3gUia74Q5U8aPpkVlQiR66CFjrLBtxrpxc
         H+iUv/wT0LnpQ==
From:   Jakub Kicinski <kuba@kernel.org>
To:     Nikolay Aleksandrov <nikolay@nvidia.com>,
        Zhang Changzhong <zhangchangzhong@huawei.com>
Cc:     Roopa Prabhu <roopa@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: bridge: vlan: fix error return code in
 __vlan_add()
Message-ID: <20201204154254.4c982c31@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
In-Reply-To: <b90689c4-ffa9-d3ca-2cd4-f39e84446639@nvidia.com>
References: <1607071737-33875-1-git-send-email-zhangchangzhong@huawei.com>
        <b90689c4-ffa9-d3ca-2cd4-f39e84446639@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 4 Dec 2020 12:47:07 +0200 Nikolay Aleksandrov wrote:
> On 04/12/2020 10:48, Zhang Changzhong wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> > 
> > Fixes: f8ed289fab84 ("bridge: vlan: use br_vlan_(get|put)_master to deal with refcounts")
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> 
> Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>

Applied, thanks!