Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp780326pxu; Fri, 4 Dec 2020 15:49:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJzQaakloJny7g6+4TtxLaOPzukHm82zFbfoqARv1bMXq7bNbxd78cKYiAYBlgMZ7/xSPIVY X-Received: by 2002:a50:fa9a:: with SMTP id w26mr10219743edr.299.1607125785116; Fri, 04 Dec 2020 15:49:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607125785; cv=none; d=google.com; s=arc-20160816; b=wi/tVIoX7RHSsLSVaZkDcQ3JN2lniSbnZL+oIo2C/KYrT7uNy5GM0plhBWP0EBnwFw A/+dcZysslhZVy27TCLSkgOv1ga+GXh02EY2PyzzkUuB6RVxeOyAHu1yrNNoVU4NTBRu X3s4NpD3D00ZB9hMm7E+Zfah/ecJciVdXWeSy/MY+gq70+Fo3JHNeNWZR8poYtlhqqxv 9XBcEuphbLIBiCQCV0hXilj1cfuwfhykm0etD5TXw3QHqONd8ujBZnXdHa/813F26ggy WnfZ/aGwHAx9/YAAc6PtEw1raTtTrgNA8ytJkD13huvWqZk+ufM9th9L3ihM9weo9/eN ABxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature :date; bh=+0jJmYe96tKfDBV+7BHwwlZzzQJNBAlclsan5Psb6dQ=; b=ctzVX5G68PbmK0I71sdRXdOmJ9+1ZrHHVbGCtOmx+Lf6aClKLm+nkW4d1hyZ+GxF+i Qe52vOoHqHVMzwl9rIzaD1GFjeeCqkJLK1v4rzkxq/6A//AWQ6TQQXcHwWpAjKoGnfmr 1mO0VSuCgig9h0QajgZjJ7+Ryu3yGZIZV5RoDxuwfyGN2j9apW6425Uj9BX1XbI57A/S Zc+Wf5EhnM8yJ7Qyx96Np/xGnFotxtwQnaJehzhyTQudBhh5RyxY8oO4hHjX5oKQ0VDT t9vdMyKbrqf/R1LShUqGC9uSjn/FLXMM1coqmETiN+JVi5l1oqdvFTGCNOyqRC/w61R0 d8bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZXfIOdp0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j11si3842147edy.158.2020.12.04.15.49.22; Fri, 04 Dec 2020 15:49:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZXfIOdp0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730869AbgLDXpT (ORCPT + 99 others); Fri, 4 Dec 2020 18:45:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:44124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726868AbgLDXpS (ORCPT ); Fri, 4 Dec 2020 18:45:18 -0500 Date: Fri, 4 Dec 2020 15:44:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607125492; bh=t1iAV5AIC3nrJes6h0m7zblB4Bw7MJPcnXdRTGhhU+g=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=ZXfIOdp0eRvROycO9EJestm1joqnRfhwchN+u0AxHiLuIzM6QndtVtbXPhBwu1s6t 5Axb0Lyf8Si4IvJwukiIX1ZmtOaiRQFuxJ34u+YIRbq+VH36OqKSRuVzMCqHOMY6JJ LiLHvBXZs3SvORC7Y+kE1VSJeBiWeYL5YQjUACKVMDEza0qPisjwkRYyoEuLBp2hqL x4OLfixlA+cDyUE7wgxZsMWCpZtVPhErhaUdd6/9qetjfVl+V6c2sln8BwTAl2yB+I kcp2pzZYLR/NfBoelqt54kAL+CQuacs2y2v4Ws/PGed5e7TxSnSjrFZgwof10aNAM/ 9nx27TFgyllog== From: Jakub Kicinski To: "Eelco Chaudron" , "Wang Hai" Cc: pshelar@ovn.org, davem@davemloft.net, dev@openvswitch.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] openvswitch: fix error return code in validate_and_copy_dec_ttl() Message-ID: <20201204154451.011d9034@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> In-Reply-To: <40A832BA-4065-4FB2-9C33-D41CF4B336CF@redhat.com> References: <20201204114314.1596-1-wanghai38@huawei.com> <40A832BA-4065-4FB2-9C33-D41CF4B336CF@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 04 Dec 2020 13:07:48 +0100 Eelco Chaudron wrote: > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Changing 'return start' to 'return action_start' can fix this bug. > > > > Fixes: 69929d4c49e1 ("net: openvswitch: fix TTL decrement action > > netlink message format") > > Reported-by: Hulk Robot > > Signed-off-by: Wang Hai > > Thanks for fixing! > > Reviewed-by: Eelco Chaudron Applied, thanks!