Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201106020305.767202-1-pmalani@chromium.org> <20201120073201.GA4120550@kuha.fi.intel.com>
In-Reply-To: <20201120073201.GA4120550@kuha.fi.intel.com>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Fri, 4 Dec 2020 17:09:19 -0800
Message-ID: <CACeCKadt_=4+Xc+8OojSg7isXgL2dhfnaUHCMKhtDe_HwPQwdQ@mail.gmail.com>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: Tolerate unrecognized mux flags
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Keith Short <keithshort@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Friendly ping. If there are not other reservations, can we pick this
patch? It doesn't depend on any other patch series.

Thanks,

On Thu, Nov 19, 2020 at 11:32 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> On Thu, Nov 05, 2020 at 06:03:05PM -0800, Prashant Malani wrote:
> > On occasion, the Chrome Embedded Controller (EC) can send a mux
> > configuration which doesn't map to a particular data mode. For instance,
> > dedicated Type C chargers, when connected, may cause only
> > USB_PD_MUX_POLARITY_INVERTED to be set. This is a valid flag combination
> > and should not lead to a driver abort.
> >
> > Modify the mux configuration handling to not return an error when an
> > unrecognized mux flag combination is encountered. Concordantly, make the
> > ensuing print a debug level print so as to not pollute the kernel logs.
> >
> > Cc: Keith Short <keithshort@chromium.org>
> > Signed-off-by: Prashant Malani <pmalani@chromium.org>
>
> FWIW:
>
> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> > ---
> >  drivers/platform/chrome/cros_ec_typec.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> > index ce031a10eb1b..5b8db02ab84a 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -537,10 +537,9 @@ static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,
> >               port->state.mode = TYPEC_STATE_USB;
> >               ret = typec_mux_set(port->mux, &port->state);
> >       } else {
> > -             dev_info(typec->dev,
> > -                      "Unsupported mode requested, mux flags: %x\n",
> > -                      mux_flags);
> > -             ret = -ENOTSUPP;
> > +             dev_dbg(typec->dev,
> > +                     "Unrecognized mode requested, mux flags: %x\n",
> > +                     mux_flags);
> >       }
> >
> >       return ret;
> > --
> > 2.29.1.341.ge80a0c044ae-goog
>
> thanks,
>
> --
> heikki