Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp833543pxu; Fri, 4 Dec 2020 17:29:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJzO6UOxwPjftiw1mxHgpHCGzQeE1IlGVWbzulLuO0rTF2lOUmqrYPeNir7CvJLRwqZrdCBZ X-Received: by 2002:a17:906:1151:: with SMTP id i17mr9963888eja.250.1607131771496; Fri, 04 Dec 2020 17:29:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607131771; cv=none; d=google.com; s=arc-20160816; b=Gm0QMwqQuGLwwEF3vzSChULFt8Kuhc0AzIRQuVMRhhqND9XHsEPiZpVjG7dVXDnrJL R+TYrmEP5DnD1JqNJjneK1I/ho4ck52VMVceS0tqPJnlipZY/AR00AYip2QRct5H9NVE YLITUEx8JJE3A1aVFmQglXaIeTmuI6BAEZAAFw+SqhddD92U15yy8YGsus6IPf5Kq67A QfLfGKDB6ODnqcjPF2Js607MnMzeXD+xV9HMz8XHeqJJwWTdcc+8g6jG+4pbfQ5Xwoes rRz501O4w4PUT13BIVZaR6q7wzjCwm8MYRYNV99QIkTgnnBduQHqath+dvkES4BJo3oc cp9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:dkim-signature :date; bh=BndOLmDfrnmCQkFZYxTv+cKTW/vDkLUOJvp1CyetZHQ=; b=grNZsaQQVyJctSrhWBzp8BasXDOI6GcRF92yGlX7CWRW5Cje6RFvzekPneThXBGUnm AEB1ESjpCIz8kcU2Ba/arqJammd9F0VrV3sH6KskkY8D8bdLnIEPxSeu0sYieYnpZVXT cZNuyXeYy4N07yZRg7RFKBq44CH070ihqiyMue29+GjN5sCkUOYq+2wlGHtDYLCRpRp1 v3ad+aZPv/sik6DQkeT9xCAf8VykAtAPHxBlRLZD1qwuunmttcnr5Hy7PuU9uXHqCscW dW3JSy5BgIochM7eB06wcwtONwzicvqmdRQFX0Y3o4T1YpfsjnMGDA9ozUynd8/uXbmu K57w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=yg33d0k0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t27si2377325eje.510.2020.12.04.17.29.07; Fri, 04 Dec 2020 17:29:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=yg33d0k0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728429AbgLEB0D (ORCPT + 99 others); Fri, 4 Dec 2020 20:26:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:53238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726210AbgLEB0D (ORCPT ); Fri, 4 Dec 2020 20:26:03 -0500 Date: Fri, 4 Dec 2020 17:25:21 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1607131522; bh=GjUSlecWxBxHbnsCJmgbVCyqlcg2RO9TS2Mad7tkdB0=; h=From:To:Cc:Subject:In-Reply-To:References:From; b=yg33d0k0YWAbij4DhLtRIMLjs+i8EZqXOsyEVltAzBNjw5EGsvOlonYgvki8qVIyW U7xCaU51IaUJAZQIwOvq+3sCbzFC7rLANXrzEy6aF94x9+2OKhab8IDx/geiwlYie8 t9Orxy/sIjWNmB07TegVDFCJSwNrdqzZ1dd7YdSY= From: Andrew Morton To: Kuan-Ying Lee Cc: "qiang.zhang@windriver.com" , "sfr@canb.auug.org.au" , "aryabinin@virtuozzo.com" , "dvyukov@google.com" , "andreyknvl@google.com" , "qcai@redhat.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Subject: Re: [PATCH] kasan: fix slab double free when cpu-hotplug Message-Id: <20201204172521.ed9f77164ff9f9fc91f35ee0@linux-foundation.org> In-Reply-To: <1607083295.22062.15.camel@mtksdccf07> References: <20201204102206.20237-1-qiang.zhang@windriver.com> <1607083295.22062.15.camel@mtksdccf07> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 4 Dec 2020 20:01:35 +0800 Kuan-Ying Lee wrote: > > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c > > index d98b516f372f..55783125a767 100644 > > --- a/mm/kasan/quarantine.c > > +++ b/mm/kasan/quarantine.c > > @@ -194,7 +194,6 @@ bool quarantine_put(struct kmem_cache *cache, void *object) > > > > q = this_cpu_ptr(&cpu_quarantine); > > if (q->offline) { > > - qlink_free(&meta->quarantine_link, cache); > > local_irq_restore(flags); > > return false; > > } > > Hi Qiang, > > Thanks for fixing this. > Due to that issue, my commit has been removed by Stephen from > linux-next. > > > Hi Stephen, Andrew, > > Should I directly upload the v4 or Stephen can pick the commit which > has been removed back to the linux-next. I took care of it. Restored the original patch and added this one as a -fix.