Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Khalil Blaiech <kblaiech@nvidia.com>
To:     Xu Wang <vulab@iscas.ac.cn>
CC:     "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] i2c: mlxbf: Fix an error pointer vs NULL check
Thread-Topic: [PATCH] i2c: mlxbf: Fix an error pointer vs NULL check
Thread-Index: AQHWyhDoj0ka6v+8ck2WlhCtrpC+eannubJw
Date:   Sat, 5 Dec 2020 01:39:32 +0000
Message-ID: <MN2PR12MB361677235F0526AC99E0B3C2ABF00@MN2PR12MB3616.namprd12.prod.outlook.com>
References: <20201204074111.1359-1-vulab@iscas.ac.cn>
In-Reply-To: <20201204074111.1359-1-vulab@iscas.ac.cn>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 21743907-df07-4d2d-282f-08d898be9d40
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2020 01:39:32.1321
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 836CczZhdVzEPF6Y3KnMbvrlpqemEVGeTtBRawSQYm6m/8BagKa/am85ow5UdHQqDdCNGK/8eAGhMh4YUlENvQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3519
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1607132375; bh=gHfriSMyGW5dJnTsGlLgqkETO+igvkQ2qXFVRyHDE/M=;
        h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:
         CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:
         In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach:
         X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
         x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
         x-ms-traffictypediagnostic:x-microsoft-antispam-prvs:
         x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck:
         x-microsoft-antispam:x-microsoft-antispam-message-info:
         x-forefront-antispam-report:x-ms-exchange-antispam-messagedata:
         x-ms-exchange-transport-forked:Content-Type:
         Content-Transfer-Encoding:MIME-Version:
         X-MS-Exchange-CrossTenant-AuthAs:
         X-MS-Exchange-CrossTenant-AuthSource:
         X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-originalarrivaltime:
         X-MS-Exchange-CrossTenant-fromentityheader:
         X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
         X-MS-Exchange-CrossTenant-userprincipalname:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
        b=Cnl/OnjxkLVSp7brxzcczMRmpCLb+J9aDqy2EYr3vMm1wj9K++SQKoNPQoH3PJZ0+
         dYg++1jnrtgDnWF+qcJ3Y/yuMdmtDP5av1ROPOHcYt66CcW4RYK4Z6iH3ZhmkifbVk
         u39uT8GJewruf2UnqjKkOprg/DZ5ThRVKZMO419Cal6DGeD7HDjKHBWKagsKM93W4+
         5G3YY5UWtYDFby7f1t+ToiFGBxZO1vmYE4mR25BQQreKFGVZ9be6Lk8HhEmFb2gBVW
         lzdKcV3QQO0SJ6kiE3ZfwTyQI5LPI6DpmcSFBRI6u37K6fDL1zl6JMV8LqNRem3uxV
         OFW9RZuYngHIw==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> In case of error, the function devm_ioremap() returns NULL pointer not
> ERR_PTR(). The IS_ERR() test in the return value check should be
> replaced with NULL test.
>=20
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Thank you very much for your patch. Please note that previous patch
has been posted to address this issue.

> ---
>  drivers/i2c/busses/i2c-mlxbf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxb=
f.c
> index 33574d40ea9c..73a58beb7b82 100644
> --- a/drivers/i2c/busses/i2c-mlxbf.c
> +++ b/drivers/i2c/busses/i2c-mlxbf.c
> @@ -1258,9 +1258,9 @@ static int mlxbf_i2c_get_gpio(struct
> platform_device *pdev,
>  		return -EFAULT;
>=20
>  	gpio_res->io =3D devm_ioremap(dev, params->start, size);
> -	if (IS_ERR(gpio_res->io)) {
> +	if (!gpio_res->io) {
>  		devm_release_mem_region(dev, params->start, size);
> -		return PTR_ERR(gpio_res->io);
> +		return -ENOMEM;
>  	}
>=20
>  	return 0;
> @@ -1323,9 +1323,9 @@ static int mlxbf_i2c_get_corepll(struct
> platform_device *pdev,
>  		return -EFAULT;
>=20
>  	corepll_res->io =3D devm_ioremap(dev, params->start, size);
> -	if (IS_ERR(corepll_res->io)) {
> +	if (!corepll_res->io) {
>  		devm_release_mem_region(dev, params->start, size);
> -		return PTR_ERR(corepll_res->io);
> +		return -ENOMEM;
>  	}
>=20
>  	return 0;
> --
> 2.17.1