Date: Wed, 30 Aug 2006 14:20:45 -0700
From: Andrew Morton <akpm@osdl.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: David Howells <dhowells@redhat.com>, axboe@kernel.dk,
       linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/19] BLOCK: Make it possible to disable the block
 layer [try #6]
Message-Id: <20060830142045.c87f341e.akpm@osdl.org>
In-Reply-To: <1156971999.5787.12.camel@localhost>
References: <20060829180552.32596.15290.stgit@warthog.cambridge.redhat.com>
	<20060829180634.32596.4507.stgit@warthog.cambridge.redhat.com>
	<20060830124400.23ca9b38.akpm@osdl.org>
	<1156971999.5787.12.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1071
Lines: 24

On Wed, 30 Aug 2006 17:06:39 -0400
Trond Myklebust <trond.myklebust@fys.uio.no> wrote:

> > This function is misnamed and is implemented in the wrong place.  It's not
> > really a block thing at all.  If/when/soon NFS starts to implement it and
> > call it, things will need to be renamed and reshuffled.
> 
> Already done in the NFS git tree. See attached patch.

Right, I saw that, didn't know that you'd merged it yet.  Ho hum, yet
another reject to fix up.

I think your patch is a bit minimal: at adds blk_congestion_end() whereas
it'd make better sense longer-term to remove blk_congestion_wait() and
blk_congestion_end() altogether, replace them with something which is
somewhere else and which doesn't mention "blk".  I expected this to be done
four years ago ;)

But not now.  Nobody's allowed to touch anything else!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/