Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: wHda7EZLOvb98ckR8KPP5TtWrs6QCzp4puA4o3VdgtvIZRMK7owkDKoTOT6+VCHM/kag0yiilT
 wQL3s1AnVj2V56PrL1kpZogQK+jQuauIFlXppOaiMyMGKlz91lbdIWFYYHjUTWsZH4Yj92enbA
 jvhBjt1hMqnQufTZRiDTtejbu85EpTJHLd72piDjJe8/hRWoCGC7zx9I31a/tmby7xhvkxedBU
 yMrjjKe9D6fwNjjBDDApJy4uLjsuk5b/m3FZIInxsMM48KfD5zCuGS7153g7rzIe5jPTGXzlNP
 BYs=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Stanley Chu <stanley.chu@mediatek.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>
CC:     "beanhuo@micron.com" <beanhuo@micron.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuohong.wang@mediatek.com" <kuohong.wang@mediatek.com>,
        "peter.wang@mediatek.com" <peter.wang@mediatek.com>,
        "chun-hung.wu@mediatek.com" <chun-hung.wu@mediatek.com>,
        "andy.teng@mediatek.com" <andy.teng@mediatek.com>,
        "chaotian.jing@mediatek.com" <chaotian.jing@mediatek.com>,
        "cc.chou@mediatek.com" <cc.chou@mediatek.com>,
        "jiajie.hao@mediatek.com" <jiajie.hao@mediatek.com>,
        "alice.chao@mediatek.com" <alice.chao@mediatek.com>,
        "huadian.liu@mediatek.com" <huadian.liu@mediatek.com>
Subject: RE: [PATCH v4 0/8] Refine error history and introduce event_notify
 vop
Thread-Topic: [PATCH v4 0/8] Refine error history and introduce event_notify
 vop
Thread-Index: AQHWyq/pOn7SLSBA3UysiLzNTb9IZ6noIz6g
Date:   Sat, 5 Dec 2020 08:03:10 +0000
Message-ID: <DM6PR04MB65758A2779FD814F52E137BAFCF00@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201205023938.13848-1-stanley.chu@mediatek.com>
In-Reply-To: <20201205023938.13848-1-stanley.chu@mediatek.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 28860163-703e-4505-cd8e-08d898f435cc
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2020 08:03:11.3189
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3xwCe9TUgtjgxDBb5va5WDU7YBxcTcP8kN8XqN+J4ofopp1Higy/xLPgievzORS/ZgEEgHuqouled/8bSxgHVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6667
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stanley,
Will you split this series to 3 separate series:
Phy initialization cleanup, Error history, and event notification?
As those 3 aren't really connected?

Please maintain Can's reviewed-by tag for the error history patches,
And add mine for the phy initialization, so Martin can pick those.

Thanks,
Avri

>=20
> Hi,
> This series refines error history functions, do vop cleanups and introduc=
e a
> new event_notify vop to allow vendor to get notification of important
> events.
>=20
> Changes since v3:
>   - Fix build warning in patch [8/8]
>=20
> Changes since v2:
>   - Add patches for vop cleanups
>   - Introduce phy_initialization helper and replace direct invoking in uf=
s-cdns
> and ufs-dwc by the helper
>   - Introduce event_notify vop implemntation in ufs-mediatek
>=20
> Changes since v1:
>   - Change notify_event() to event_notify() to follow vop naming coventio=
n
>=20
> Stanley Chu (8):
>   scsi: ufs: Remove unused setup_regulators variant function
>   scsi: ufs: Introduce phy_initialization helper
>   scsi: ufs-cdns: Use phy_initialization helper
>   scsi: ufs-dwc: Use phy_initialization helper
>   scsi: ufs: Add error history for abort event in UFS Device W-LUN
>   scsi: ufs: Refine error history functions
>   scsi: ufs: Introduce event_notify variant function
>   scsi: ufs-mediatek: Introduce event_notify implementation
>=20
>  drivers/scsi/ufs/cdns-pltfrm.c        |   3 +-
>  drivers/scsi/ufs/ufs-mediatek-trace.h |  37 ++++++++
>  drivers/scsi/ufs/ufs-mediatek.c       |  12 +++
>  drivers/scsi/ufs/ufshcd-dwc.c         |  11 +--
>  drivers/scsi/ufs/ufshcd.c             | 132 ++++++++++++++------------
>  drivers/scsi/ufs/ufshcd.h             | 100 +++++++++----------
>  6 files changed, 175 insertions(+), 120 deletions(-)
>  create mode 100644 drivers/scsi/ufs/ufs-mediatek-trace.h
>=20
> --
> 2.18.0