Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0n/vUQhDyhOAC3rSy5knG33exjKkUSFOKsB6CtkWWATuTeQlndA9V7FSmYebqtrAkl3NaO6iij
 vWttOAHuXupMTK2fJLGavW1O+lkV/baQBAiUMJ0EYEAcszGHY3m08FrMtxXnXV4vPEm4ZO/ZN7
 d5xnk7VlhvFrNaKQ9b+Q5fDn4nubm5eb7kfOoD42oOh58xJW3Tj5HYs+UAt2zD2wr2bQZcU0us
 Ytsd7orpOZZWPnviXk7LaIDcZqVsskVIEwRgu77qST1ifZp0kuMC8EKlaX4n0Iz/JnIoI1cTnO
 6pg=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Jaegeuk Kim <jaegeuk@kernel.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Can Guo <cang@codeaurora.org>,
        Asutosh Das <asutoshd@codeaurora.org>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "clang-built-linux@googlegroups.com" 
        <clang-built-linux@googlegroups.com>
Subject: RE: [PATCH] ufshcd: fix Wsometimes-uninitialized warning
Thread-Topic: [PATCH] ufshcd: fix Wsometimes-uninitialized warning
Thread-Index: AQHWycQXp6g3K07ih063gLNOLCVad6noJ+8Q
Date:   Sat, 5 Dec 2020 08:11:32 +0000
Message-ID: <DM6PR04MB6575519252EE03084136683CFCF00@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201203223137.1205933-1-arnd@kernel.org>
In-Reply-To: <20201203223137.1205933-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f148da8-b97a-465d-9b8b-08d898f560b0
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2020 08:11:32.8934
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WZ+oNriRy4FtAVEm2YpFZGJGwlzbDSzE0MeQg7JPDr/XV14+PvP/PJtOsVuhyDI7Dtl7oNcBMA0JjDQBu+5+uA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1132
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> clang complains about a possible code path in which a variable is
> used without an initialization:
>=20
> drivers/scsi/ufs/ufshcd.c:7690:3: error: variable 'sdp' is used uninitial=
ized
> whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
>                 BUG_ON(1);
>                 ^~~~~~~~~
> include/asm-generic/bug.h:63:36: note: expanded from macro 'BUG_ON'
>  #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (=
0)
>                                    ^~~~~~~~~~~~~~~~~~~
>=20
> Turn the BUG_ON(1) into an unconditional BUG() that makes it clear
> to clang that this code path is never hit.
>=20
> Fixes: 4f3e900b6282 ("scsi: ufs: Clear UAC for FFU and RPMB LUNs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/scsi/ufs/ufshcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index f165baee937f..b4f7c4263334 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -7687,7 +7687,7 @@ static int ufshcd_clear_ua_wlun(struct ufs_hba
> *hba, u8 wlun)
>         else if (wlun =3D=3D UFS_UPIU_RPMB_WLUN)
>                 sdp =3D hba->sdev_rpmb;
>         else
> -               BUG_ON(1);
> +               BUG();
>         if (sdp) {
>                 ret =3D scsi_device_get(sdp);
>                 if (!ret && !scsi_device_online(sdp)) {
> --
> 2.27.0