Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 5 Dec 2020 09:58:05 +0100
From:   Dominik Brodowski <linux@dominikbrodowski.net>
To:     Wei Li <liwei391@huawei.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Olof Johansson <olof@lixom.net>, linux-kernel@vger.kernel.org,
        guohanjun@huawei.com
Subject: Re: [PATCH] drivers/pcmcia: Fix error return code in
 electra_cf_probe()
Message-ID: <X8tLnWhuUhTjwnH4@light.dominikbrodowski.net>
References: <20201124070040.3583-1-liwei391@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201124070040.3583-1-liwei391@huawei.com>
Precedence: bulk

Am Tue, Nov 24, 2020 at 03:00:40PM +0800 schrieb Wei Li:
> When it fails to call of_get_property(), it just jumps to 'fail1',
> while the 'status' which will be returned is not updated.
> 
> Fixes: 2b571a066a2f ("pcmcia: CompactFlash driver for PA Semi Electra boards")
> Signed-off-by: Wei Li <liwei391@huawei.com>

Thnaks for the patch. However, this issue is already fixed by
commit f15480e947d4 ("pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()'
in case of error")
in pcmcia-next.

Thanks,
	Dominik