Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1178431pxu; Sat, 5 Dec 2020 06:35:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJwMb892T3DNraCQthCXFbGmbtpIafAJwYQ03BC2ICuyyemwC2vDUquyYDsNnmXk179zTzWT X-Received: by 2002:aa7:ce94:: with SMTP id y20mr12132089edv.361.1607178907817; Sat, 05 Dec 2020 06:35:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607178907; cv=none; d=google.com; s=arc-20160816; b=iDnngKuXU5Px0AQxOjrge+G071XlKrt/m8zUgZKe/xf4g5u8Fe9Ee4nxn9ceFOkHIR Nacb5joY2v6VzGKxUeVE24HFODl2NvVPUB9dm2yw/+AUxFUCuPAwGA6OyHFiYRwGQDaK 8BqBEcTqAWmVqNpVgsMaRxuxX5KFgRlRIL5y/4vz1LUtf09Y64KXMCcxeJzDfLqAFeRL dNZ+NFnK2zPp61kSo2uEVDNb2865Zq30HMrkO3bwiz3KqImduGDXadpShcPWj2N0R2ry s6P6KJlbZFfuwy7tgYMPPMSMl+z8RyyvRmiMiHKvTs9AiLDiE03WvDjyBXVNi97SawF2 cgEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=3zrnY7BVt5+j+uOkAr/wReG8asjC6gOXFzK/8g/9V+8=; b=PxN/iLS7lWMFIKa4YI9jdGdkO94Td3L4QIl1fQ/XmBZIoOqjoHp7Bnk2e2PQ8BQt0l PA3Br7MwUKN651UCfGzU1CmihQYyHQxm3s1NGzqbw5Q3xClO1Xs3QoMSSqresd/ZDMoL QKgDa/9Gq7LCks3OpGrIiNumqGenU17tRjT8UpaNDTpNasSPzHobARcCJeQYBR38530Z V0FtLoKhJdFGi37Pxvsz4/QaDE+01c9f9KaDUcH9/Ne6ASGgYtI/kMe5GaeC990hQ1Yp UzRUty4VnMqTTzpwUflW66A3QRtHqKbPEtIX5QSiEWZrvWC0y2tgjYLZSPSfQbn1x1H8 6vRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d1si1872124edr.28.2020.12.05.06.34.41; Sat, 05 Dec 2020 06:35:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726225AbgLEO3C (ORCPT + 99 others); Sat, 5 Dec 2020 09:29:02 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:41072 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726130AbgLEM5s (ORCPT ); Sat, 5 Dec 2020 07:57:48 -0500 X-UUID: b183c6f04f444e03a00761b64ae11f96-20201205 X-UUID: b183c6f04f444e03a00761b64ae11f96-20201205 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1550523132; Sat, 05 Dec 2020 20:01:05 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs02n1.mediatek.inc (172.21.101.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 5 Dec 2020 20:00:40 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 5 Dec 2020 20:00:42 +0800 From: Stanley Chu To: , , , , CC: , , , , , , , , , , , , , , , , Stanley Chu Subject: [PATCH v1 4/4] scsi: ufs-dwc: Use phy_initialization helper Date: Sat, 5 Dec 2020 20:00:41 +0800 Message-ID: <20201205120041.26869-5-stanley.chu@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20201205120041.26869-1-stanley.chu@mediatek.com> References: <20201205120041.26869-1-stanley.chu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use phy_initialization helper instead of direct invoking. Reviewed-by: Avri Altman Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufshcd-dwc.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd-dwc.c b/drivers/scsi/ufs/ufshcd-dwc.c index 6a901da2d15a..5bb9d3a88795 100644 --- a/drivers/scsi/ufs/ufshcd-dwc.c +++ b/drivers/scsi/ufs/ufshcd-dwc.c @@ -120,13 +120,10 @@ int ufshcd_dwc_link_startup_notify(struct ufs_hba *hba, if (status == PRE_CHANGE) { ufshcd_dwc_program_clk_div(hba, DWC_UFS_REG_HCLKDIV_DIV_125); - if (hba->vops->phy_initialization) { - err = hba->vops->phy_initialization(hba); - if (err) { - dev_err(hba->dev, "Phy setup failed (%d)\n", - err); - goto out; - } + err = ufshcd_vops_phy_initialization(hba); + if (err) { + dev_err(hba->dev, "Phy setup failed (%d)\n", err); + goto out; } } else { /* POST_CHANGE */ err = ufshcd_dwc_link_is_up(hba); -- 2.18.0