Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1299055pxu; Sat, 5 Dec 2020 10:37:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIdXBawd+pcDZ5W9fSXM9odTUoh4GNiDye8Zp1GKNHYfQyz+PW1R0KOrFoQEF0QUWOTjNL X-Received: by 2002:a05:6402:2074:: with SMTP id bd20mr12917389edb.326.1607193454717; Sat, 05 Dec 2020 10:37:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607193454; cv=none; d=google.com; s=arc-20160816; b=xGw0NhWyADkZJDH0RWXOHnPCDhs0qSgg66GHDVVLnHeX4RuYfbcJGwLjQSc88eL02l W9MsbSjN+gRG2BS9C4b3WhUp/Y7Vr63t1hxFl4fr3nxTShRBGbKrpxiKWavMSiCKPNV0 6VcHqAVEYwPxUtTYW94IyqXEi7g2l/sABOvzhl+P+UbTNrtq49f/ePoEo8dxbhEEiaVj KUXkHf+BY6yro1fae5ppWDV0HvbnY4GeYNhipyvlvQFuOU4a3JGVdAneSiMMrSbV0c3Y f+8lX+BQkenIKLtsSOaxNq6Evkbva3a8X6U3F4afWBLMsJ1lVz0CqYRkxF/EAh+29l/0 RJYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=YOdygsnRTcmY5yyVYCdXMa08JVvP1+QIC39sK4BshGQ=; b=nBK2PWFOVu8T5n/OsOso8U5n4Yz4WMURT6STeEJxzEMzylt5cbG5D2gNnhnDOWoUWj WKZK7HD5OpSNVqYvSN/flRP9wyc8WhgaHveivph1hGpW17U4aabyXrxeREKqN7ykJpzZ hy6SqZJrE3mz9D8FFv2tDmAzF9P7KQmhxMXSaSFnO+P8mRpu/LX1ThW1WOIQveDSdN/8 eowPi6dnkd5S4VM2TC9wF6IEY38qS45+tKXXE0+RVyWAn6iDi/wjiaXT9DMwAh/2r3FG Yp5j61lWR+78MuR81dn3iH2W5PNnus37/GjE/h1zXdPQdJvs24Yt2M5LkXVZcrMel3T1 BNjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=RiNPDmiw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m10si5460918eds.453.2020.12.05.10.37.11; Sat, 05 Dec 2020 10:37:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=RiNPDmiw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729702AbgLESTi (ORCPT + 99 others); Sat, 5 Dec 2020 13:19:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727834AbgLERqn (ORCPT ); Sat, 5 Dec 2020 12:46:43 -0500 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C62E8C094268; Sat, 5 Dec 2020 05:14:41 -0800 (PST) Received: by mail-ed1-x544.google.com with SMTP id u19so8794074edx.2; Sat, 05 Dec 2020 05:14:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YOdygsnRTcmY5yyVYCdXMa08JVvP1+QIC39sK4BshGQ=; b=RiNPDmiwqdFc1DJHL8RCiXpBzhQxZt5gZVftzubtM7mE+TLT3+b20CfiR2Jh6TBsMX dXvqnnKrJWni8XXN4dl0ALFQ1fS0PRwKJkR3lSbOVt6qLQDGEZ2YAWrUzf6bBnMuEm7n y5j4xWQk/bAECDd+Pl1Y+hX+MGmhdk04KaVgKUWqcsmzzDJuUcqyvxd+ThQ1GBwkRa2+ JpmggYQqfbpNXmL+sXYYq4llUtqDS82UeKlnU+3SmPCg901NRkuCjO8MtE2dAMAJ6hf1 kpgiRmJWgR3yjJj6uZ570VCz/DsdrpsLWkc8d2tYTU5h1Z8aLdd89xHxhNy5QDg6vgVC FEvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YOdygsnRTcmY5yyVYCdXMa08JVvP1+QIC39sK4BshGQ=; b=r/MRKz9CL+RRWpKlyi9IBCdEB/POkEgnkqNdG/Ufp0Zlcxu8mMEX+1lUbvvlsFzF7N kBj/v24y3Rzqr/tBxHdnS51oSECB2j/CtBYAURx80aVcmicIIwZ7OTO6V33B6zN1ZDV1 3d9DLp7Vp6vxYlAPRZuBYjiz6w24Hm1yv61QGq0I5JpZGhzecbwtpss+shPYBlZPofni GOEhYYaXILRlQvddSWrFX4DvJ0ZsgVQFqC55Ege6ETQlAUNPso9eLcHEXst1YoqgPFpz 0cDmlIEEF19vZSzzGSTa+rrQy4oBknH/G28bjgUWkACVsJe8xSZT9eA6kCU71zQvSZ1z o6Dw== X-Gm-Message-State: AOAM53153YTqILW8e178KcRPbx1f/w7oRdY3ItT22Cn18Y1EAEwYGkCZ rjFQKN1Jsg9Gvsci9Y5kKSo20SsfD0FHQDLABxw= X-Received: by 2002:a05:6402:2059:: with SMTP id bc25mr12126364edb.13.1607174080529; Sat, 05 Dec 2020 05:14:40 -0800 (PST) MIME-Version: 1.0 References: <14754fd95378b78eb9a0a3f8b6bab13f7263c7f1.1606828668.git.stefan@agner.ch> In-Reply-To: From: Martin Blumenstingl Date: Sat, 5 Dec 2020 14:14:29 +0100 Message-ID: Subject: Re: [PATCH v2 2/5] arm64: dts: meson: fix PHY deassert timing requirements To: Stefan Agner Cc: khilman@baylibre.com, robh+dt@kernel.org, Neil Armstrong , jbrunet@baylibre.com, christianshewitt@gmail.com, jian.hu@amlogic.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 2:21 PM Stefan Agner wrote: > > According to the datasheet (Rev. 1.9) the RTL8211F requires at least > 72ms "for internal circuits settling time" before accessing the PHY > egisters. This fixes an issue seen on ODROID-C2 where the Ethernet > link doesn't come up when using ip link set down/up: > [ 6630.714855] meson8b-dwmac c9410000.ethernet eth0: Link is Down > [ 6630.785775] meson8b-dwmac c9410000.ethernet eth0: PHY [stmmac-0:00] driver [RTL8211F Gigabit Ethernet] (irq=36) > [ 6630.893071] meson8b-dwmac c9410000.ethernet: Failed to reset the dma > [ 6630.893800] meson8b-dwmac c9410000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed > [ 6630.902835] meson8b-dwmac c9410000.ethernet eth0: stmmac_open: Hw setup failed > > Fixes: f29cabf240ed ("arm64: dts: meson: use the generic Ethernet PHY reset GPIO bindings") > Signed-off-by: Stefan Agner with the "registers" typo above fixed: Reviewed-by: Martin Blumenstingl