Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1302346pxu; Sat, 5 Dec 2020 10:45:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJxYxynGG2LCQpAkgozjvSPHumhTstCgj4CHIZib2Ax/8Qn4b0IyeLqyPED901cmhOYoUz86 X-Received: by 2002:a17:906:edd1:: with SMTP id sb17mr6036038ejb.118.1607193915094; Sat, 05 Dec 2020 10:45:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607193915; cv=none; d=google.com; s=arc-20160816; b=sC0n18RRPB+Djs9LHUQIUl4FUzJtHsCHhn8ha1RYdq20rmZ+3mobxH9qsIHgVRuubB 35uS67ZZ/71aR0dDkh9MN1NFzQtLjSH3FF//3j/3vE71iooO39AnGoRlaCsuLe/kRVKY rnDOIlo2H1dkCL5sGCgdJWERO5Q8Ego0ScHGPls+bGp9VcT9hwAJM1qT9D9wEV0V1o1a AZXf3VZ+/ToiweVRSJt2GWFiVuG9h6q1h12ICr4AhtKkO32WlGgaDu/6ySuHoSyfBA3J nYU4wDYCOMFcqjx2Hc3dtTHx08rQJa8qCTJwQcsUJgpzM5I9IcoBzEfNxzV8RI7p87Tu vR3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=PSWuLaWp7kbS1P3O0848/H0adnOKzlmdgp1RQ+ybx9E=; b=ovwsZJj6zInopWSmEfcG3y6UBqeYxrhBYEmkditbJS3PVT+ftwsYLm5CfyCtjyf9j/ MP0sVl5we2eTMXyCnS0etyuwX5Mz8Ifek1qYVLBRHkQZROb3WkZO3KHZufGIxDQCiMdL WBJdrI31HsFaraU/JNG2QSywDHNYoNGzB1lIS0VOuYpt2z9pOAbqvLCgdkE31wmXcP2g 7j6c/jXC7OstFgLWpJWZJGEalgTdmXPO+7CpPCKkobCC9uHW3SF5YfrNZ54izcTfY4eJ IjQmEAfdgtUa1y89IzrMGQnAYmE0SyCTQxlStWjIyl0gq1YNJMNgIL0weLdGOOf7hqW5 sTVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=DfuNWu0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a13si3785408ejc.128.2020.12.05.10.44.51; Sat, 05 Dec 2020 10:45:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=DfuNWu0n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726136AbgLESmK (ORCPT + 99 others); Sat, 5 Dec 2020 13:42:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726629AbgLERic (ORCPT ); Sat, 5 Dec 2020 12:38:32 -0500 Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D954C094267; Sat, 5 Dec 2020 05:14:24 -0800 (PST) Received: by mail-ed1-x541.google.com with SMTP id i24so920821edj.8; Sat, 05 Dec 2020 05:14:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PSWuLaWp7kbS1P3O0848/H0adnOKzlmdgp1RQ+ybx9E=; b=DfuNWu0nvI/vVGwzISzLSSGehEluoo+f6F2w8cnNEFZ6a5Yg2UrKW+I9A+SOR4/Y9R 12c1zdDfc88FUXJ67ZddR7xaLyOd5DnO9WKZYsgYatjFSXOY7moPGweTQCCC7p80LKyc UL+ri58kmYox4rh31GYuaGdK7VI0dfTzYbM09MSxZf4YRJ2wlrzXi/e6bmt2IpQ4zy75 X8oOVyrKZkkYE7JVDH39hOY8EZt21JZT8E7i//I1ME5t6VPD6EyHXZ0EIYo3X7YzG3V5 ol/hHsJ/T9Jen4j89EYlphWclFthOV+h4p65gd0BgAiuDi6Mis8/o3fhJeqyecOtS966 G5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PSWuLaWp7kbS1P3O0848/H0adnOKzlmdgp1RQ+ybx9E=; b=i5rF2LOA+FkTAZ6Rs2rqdZyD3HHTREv+GXKkcS7NwW7Wp/wC+F4hJf0GTTV5Bcs7kl Z+t3ewwdND7YfiGHR2h5/7FluWhZ3FY8lu6BVZxovKv5cw/5RLuU6pMJippaMbdij//5 Qw5qSp9CWF5T7/3Xt+cFnA7Thc6r0WP2OGtbAZnTut8YdFoXML+PfyEI9vyXt8FhGMWI C6k4U1DJlBy4GuXQvQJoV8x5ooVgWw8vx2i3f05UL+lhTQxFTDum8Vyza79T6jk5sm09 3iXpQpy1ZasbrmLJP3+iZCjqgc6RrpzgKA/3XFEP13es4V8zkVFnWUvVAnWij7MeylTC 8ZHA== X-Gm-Message-State: AOAM531kSyT4o8GzimPk0fkzBW7VHKMJaSwXdcEZoXnbUA8eLYiQr8p/ 0OMOWgc6Y8V30FEc0XnXXRxDJhFP0JFRjONW0bgHoc3j458= X-Received: by 2002:a50:fd18:: with SMTP id i24mr12318534eds.146.1607174062920; Sat, 05 Dec 2020 05:14:22 -0800 (PST) MIME-Version: 1.0 References: <14754fd95378b78eb9a0a3f8b6bab13f7263c7f1.1606828668.git.stefan@agner.ch> In-Reply-To: <14754fd95378b78eb9a0a3f8b6bab13f7263c7f1.1606828668.git.stefan@agner.ch> From: Martin Blumenstingl Date: Sat, 5 Dec 2020 14:14:12 +0100 Message-ID: Subject: Re: [PATCH v2 1/5] arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements To: Stefan Agner Cc: khilman@baylibre.com, robh+dt@kernel.org, Neil Armstrong , jbrunet@baylibre.com, christianshewitt@gmail.com, jian.hu@amlogic.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 2:21 PM Stefan Agner wrote: > > According to the datasheet (Rev. 1.9) the RTL8211F requires at least > 72ms "for internal circuits settling time" before accessing the PHY > egisters. This fixes an issue where the Ethernet link doesn't come up > when using ip link set down/up: > [ 29.360965] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down > [ 34.569012] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31) > [ 34.676732] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma > [ 34.678874] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed > [ 34.687850] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed > > Fixes: 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line") > Signed-off-by: Stefan Agner with the "registers" typo above fixed: Reviewed-by: Martin Blumenstingl