Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201205091146.3184305-1-vkoul@kernel.org>
In-Reply-To: <20201205091146.3184305-1-vkoul@kernel.org>
From:   Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date:   Sun, 6 Dec 2020 00:21:48 +0800
Message-ID: <CAAOTY_-_X98x=DeGLnSRDcZ+9wfpW2-EzpqJLQxDJ-UGoYaONw@mail.gmail.com>
Subject: Re: [PATCH] phy: mediatek: statify mtk_hdmi_phy_driver
To:     Vinod Koul <vkoul@kernel.org>
Cc:     Kishon Vijay Abraham I <kishon@ti.com>,
        Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Chunfeng Yun <chunfeng.yun@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        DRI Development <dri-devel@lists.freedesktop.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Vinod:

Vinod Koul <vkoul@kernel.org> =E6=96=BC 2020=E5=B9=B412=E6=9C=885=E6=97=A5 =
=E9=80=B1=E5=85=AD =E4=B8=8B=E5=8D=885:11=E5=AF=AB=E9=81=93=EF=BC=9A
>
> mtk_hdmi_phy_driver is not declared as static, so statify it.
>
> drivers/phy/mediatek/phy-mtk-hdmi.c:204:24: warning: symbol 'mtk_hdmi_phy=
_driver' was not declared. Should it be static?
>

Acked-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  drivers/phy/mediatek/phy-mtk-hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c b/drivers/phy/mediatek/p=
hy-mtk-hdmi.c
> index 47c029d4b270..c5c61f5a9ea0 100644
> --- a/drivers/phy/mediatek/phy-mtk-hdmi.c
> +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c
> @@ -201,7 +201,7 @@ static const struct of_device_id mtk_hdmi_phy_match[]=
 =3D {
>         {},
>  };
>
> -struct platform_driver mtk_hdmi_phy_driver =3D {
> +static struct platform_driver mtk_hdmi_phy_driver =3D {
>         .probe =3D mtk_hdmi_phy_probe,
>         .driver =3D {
>                 .name =3D "mediatek-hdmi-phy",
> --
> 2.26.2
>