Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 5 Dec 2020 20:55:25 +0100
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        od@zcrc.me, linux-kernel@vger.kernel.org,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Christophe Branchereau <cbranchereau@gmail.com>
Subject: Re: [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel
 bindings
Message-ID: <20201205195525.GI332836@ravnborg.org>
References: <20201101093150.8071-1-paul@crapouillou.net>
 <20201101093150.8071-3-paul@crapouillou.net>
 <20201101122900.GB1269759@ravnborg.org>
 <9CZ5JQ.CWYPSJ8EDOW4@crapouillou.net>
 <CAL_JsqLSGMFibm8tVKqNe1SFBzXTU2=M2jZmpfrHeGUqS3foRg@mail.gmail.com>
 <1XJMKQ.YER47WG3D7R41@crapouillou.net>
 <CAL_JsqJDQMzHjtYa6ZCOxXW_U5nWrS+DhBj-w2myn-SkGB+KCA@mail.gmail.com>
 <MXPMKQ.PSU8COVVM0IV2@crapouillou.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MXPMKQ.PSU8COVVM0IV2@crapouillou.net>
Precedence: bulk

Hi Paul

> > >  >>  >>  +
> > >  >>  >>  +maintainers:
> > >  >>  >>  +  - Paul Cercueil <paul@crapouillou.net>
> > >  >>  >>  +
> > >  >>  >>  +allOf:
> > >  >>  >>  +  - $ref: panel-common.yaml#
> > >  >>  >>  +
> > >  >>  >>  +properties:
> > >  >>  >>  +  compatible:
> > >  >>  >>  +    const: abt,y030xx067a
> > >  >>  >>  +
> > >  >>  >>  +  backlight: true
> > >  >>  >>  +  port: true
> > >  >>  >>  +  power-supply: true
> > >  >>  >>  +  reg: true
> > >  >>  >>  +  reset-gpios: true
> > >  >>  >
> > >  >>  > The binding is missing:
> > >  >>  > required:
> > >  >>  >   - compatible
> > >  >>  >   - reg
> > >  >>  >   - power-supply
> > >  >>  >   - reset-gpios
> > >  >>  >   - ...
> > >  >>  >
> > >  >>  > additionalProperties: false
> > >  >>  >
> > >  >>  > So r-b only with these added.
> > >  >>
> > >  >>  Stupid mistake, sorry about that.
> > >  >>
> > >  >>  I'll V2.
> > >  >
> > >  > I don't have any V2 in my inbox, but looks like it is in
> > > linux-next
> > >  > now:
> > > 
> > >  Yes, Sam told me on IRC I could fix it while applying and avoid the
> > > V2.
> > > 
> > >  > /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.example.dt.yaml:
> > >  > panel@0: 'spi-max-frequency' does not match any of the regexes:
> > >  > 'pinctrl-[0-9]+'
> > >  >  From schema:
> > >  > /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml
> > > 
> > >  "make dt_binding_check
> > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml"
> > >  doesn't complain here :(
> > 
> > Even if you do 'touch
> > Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml'
> > or do a clean build?
> > 
> > I can't think of any kernel or dt-schema changes which would explain
> > the difference. This is purely related to 'additionalProperties:
> > false'.
> 
> Ok, I see it now.
> Should I use 'unevaluatedProperties: false' instead?

Yes, the issue here is that you add a number of spi properties to the
binding. And you cannot or at least shall not, list them all in this
binding.
So when evaluating the binding the spi-max-frequency should be allowed,
and when a full DT file is checked the tools will catch it there is a
binding that is not known - as you tell it with "unevaluatedProperties:
false" that all prperties must be known.

	Sam