Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1372885pxu; Sat, 5 Dec 2020 13:45:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrg577ipWq+mF2pzqSVgZoVb4J4W0xcUKuKrpbQgdgR2Dqb7xM7PNyvKB7jKWIfFNluaMV X-Received: by 2002:a05:6402:149a:: with SMTP id e26mr13532129edv.232.1607204733231; Sat, 05 Dec 2020 13:45:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607204733; cv=none; d=google.com; s=arc-20160816; b=FmYsRm4HyQIumbvWFukdLDaigFncKSLZBxpebVwH1kUhOlVKoMS1yOXG01U22x2PKC gjnuYZ4kHOQkS8Nw6Xg3WDWSWs0Ae+/Gc/rZeLg/6diIfE9Do4PCi6fGszc/y6OlvpLZ 3EqTqDNY1MCRp66vYZjfNJpA1wEBFX07xjcGzkT1YWasd/nSy02dhd+Gze922v1NG/7t a5Gwyw1MfsNpUu7VNVrxFKUVeulPLSb3h4Ob4uiNDilLJtqyMcPwqknlho9MSsJNL4lI Q2j+HP3Y3rDuetvfGyx4AA2UmWGIpgdcSrzwAbhlXxvFugvVgwLPPHhrmhEbKHtiTaGm aoZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=UTqcO35AxhvxIViibGh/0qnvfwCpCuI7G7hw7DZWNnw=; b=EfaSxVbFMTEWmw6LFgwsp6MqVY/FyiAegauVJGwDL4Iz1otc77gnROgrRzGLQiaHtm 2iXF+im55AqUg8B/GcXuaeuYyM0WrE4UTExkiAv76qefOUM7K/Sl11CzbzbW1y5sDFKY AsGJfNYMgZcqlRZ3J8BqIF2gjGLWuLSNQHEGKqir2h+v7U3EibBxoGeNik2BARrG84E7 txhhd/24SunlOBFnIKIAmUjCtYZaeW9xk5yR6fD/K7flj7iqT7U/7EDVz4BJF9AQYtEc Sdm2Ny/lRVd6AcLoeIfq6519sSquhPqqTtyj+XsDy0Xnso/C0z2b9S822CBoEFEA00xo N28g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=KXX3O1HH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 3si376876edx.407.2020.12.05.13.45.10; Sat, 05 Dec 2020 13:45:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=KXX3O1HH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726614AbgLEVlk (ORCPT + 99 others); Sat, 5 Dec 2020 16:41:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725270AbgLEVlj (ORCPT ); Sat, 5 Dec 2020 16:41:39 -0500 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A87EC0613CF; Sat, 5 Dec 2020 13:40:59 -0800 (PST) Received: by mail-ed1-x542.google.com with SMTP id cw27so9628823edb.5; Sat, 05 Dec 2020 13:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UTqcO35AxhvxIViibGh/0qnvfwCpCuI7G7hw7DZWNnw=; b=KXX3O1HHwWY11/RaM9Dzz5CFPEnVqO2861yhp3Zq4BJAOClLzmkJQU5EKrGUqCvAIr 8/9e2kWmnbhnzIeV+79jDpKC/tvBaleKhpv4uByO9genTkmUpPF5QMarNrn+m8v8oM6u 30Grfl4Zl4TvrjKwMAqtgfgOj+gwM4bv8G7vqh3+E00U+8wCFGo5fRJfzTLm8+uc+jR6 aoZPSml45VJLtp4iZsHJsQFuYUuIEHT4QPdfocOKIfVuYYmQeXKp838tIlYla+ZnIdSo mce6OSIO17VuyA6L4jHAe8j/tr9LL6GbpkliVKUV36wFqTOg++8Wx1w4FZpDGit9qqgg 5r+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UTqcO35AxhvxIViibGh/0qnvfwCpCuI7G7hw7DZWNnw=; b=CznZ+Hl5cSPtKNwQqI5BuB8ArRD/ix4gCGA/M77Sp2wc/SB4HMajeDH0TIO8le8k8M H6lu7Ki4Fr2JbttpCDl6sM0lWTwq2lxvnQTVjuzBgqX0A6Luorhwr6KA9A4IMK/2xf81 3j9Y0xRvNEnPNfTKztk1jjG3GARu7JQ8zINfItPNXDDlu0r9SXDD/khUgaAX2h9w4R44 x2LfcLHZLVbWAp6b3k4wx4W7kPwYJmz5SSeSvRS4XjoKPAFiAxS0AG3FJPA2AZ8R7aaR LKUJIpGJIID2aEtLgJW9/GND4ZMzTNwn9oIzYIkC5fBVQB79iF3GUWoRVjLBscobLyJI Hbww== X-Gm-Message-State: AOAM530mJD+qUMGrShF9ChPSjNe/Q+mzLw9VuLH2ZeZTvPxlVw/7c0eA bKhliVud2rr8evTbT51scfM1ovmm6H8CqWze5QS0zlULmIs= X-Received: by 2002:aa7:de0f:: with SMTP id h15mr1839845edv.110.1607204457924; Sat, 05 Dec 2020 13:40:57 -0800 (PST) MIME-Version: 1.0 References: <20201201190100.17831-1-aouledameur@baylibre.com> <20201201190100.17831-4-aouledameur@baylibre.com> In-Reply-To: <20201201190100.17831-4-aouledameur@baylibre.com> From: Martin Blumenstingl Date: Sat, 5 Dec 2020 22:40:47 +0100 Message-ID: Subject: Re: [PATCH v2 3/3] phy: amlogic: meson8b-usb2: fix shared reset control use To: Amjad Ouled-Ameur Cc: Kevin Hilman , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Zabel , linux-amlogic@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 8:02 PM Amjad Ouled-Ameur wrote: > > Use reset_control_rearm() call if an error occurs in case > phy_meson8b_usb2_power_on() fails after reset() has been called, or in > case phy_meson8b_usb2_power_off() is called i.e the resource is no longer > used and the reset line may be triggered again by other devices. > > reset_control_rearm() keeps use of triggered_count sane in the reset > framework, use of reset_control_reset() on shared reset line should > be balanced with reset_control_rearm(). > > Signed-off-by: Amjad Ouled-Ameur > Reported-by: Jerome Brunet Reviewed-by: Martin Blumenstingl Tested-by: Martin Blumenstingl # on Odroid-C1+