Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1376653pxu; Sat, 5 Dec 2020 13:58:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJywmoysQ+v2KyfOAtqrrzWjDqiaV0N6uYy2J1SBmI3c1F3kXgIH5xOEoe76iwx2WEhhpkCR X-Received: by 2002:a17:906:1f8e:: with SMTP id t14mr13182985ejr.350.1607205503747; Sat, 05 Dec 2020 13:58:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607205503; cv=none; d=google.com; s=arc-20160816; b=G8KFIYv+bdObga0JzIXee1e0IJHNBH4VSCLd/MDMF2Hfk8wnCltBh3nrA6/YjPZhUz DSvInjkzslcn1VH9k8UPI5AbzrmkE1qvMlymO6yo/ci+8gNyC4xTj8+ie1s4vtuYIg1S uQihPr2hMCf4R5RQr0r2dugjveVgeTDgVN9kmupNwL8lQCxlaL/uUt0qmdg0em2lg93Q k49zQeAZpb8mmd1JESfDM2GIEW6K3APA0TIuJ5umERMa4CsHlV/sgP6eEk2JPSvkMeTW aRVSDx7ew/b+85oemq7ZBTKSX2/WLLsvxgJ/9+BnDqv5OQYGIi9dO/K8OU4rFZU2NZ1p eZaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=788XxievPXArbKhvDvDluT6oiya+GFzAh5wtfB7G8D4=; b=V+UC0zG4twt7xyrEsGHQf6lY3kUf8aX6z3RQTU69i+t5cQrz7SGt4ZneVN5So3pn6d vPRLsQXBIykUFpzTWx8gmgs7Yd73+6SBPderi8XSexqHr1YgTmP2Dmii/14Hr3jyKa24 gNe1VtcXmur9W5dpVQBvSXYJCRAdj56ZfSIRtSO2mSDGYPHYzb9Tw+5lP/q6r2jFQdJe aVXokwdQ4L0YXnphKObqujMLTVjSLn2gHfmZvLJil46E2xGAFA8ejXPHjZtAm5+H3+U1 aLBtXcSUoGqaogbZr1G7jRQj8TqWRb8Bwzfsg6VQma7I9qXztgXZVbbPs/Njplc5wVlI pXpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=uks2duSw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si5329533eds.605.2020.12.05.13.57.59; Sat, 05 Dec 2020 13:58:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@googlemail.com header.s=20161025 header.b=uks2duSw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=googlemail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726948AbgLEVyS (ORCPT + 99 others); Sat, 5 Dec 2020 16:54:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbgLEVyS (ORCPT ); Sat, 5 Dec 2020 16:54:18 -0500 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A78E1C0613D4; Sat, 5 Dec 2020 13:53:37 -0800 (PST) Received: by mail-ed1-x543.google.com with SMTP id v22so9630631edt.9; Sat, 05 Dec 2020 13:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=788XxievPXArbKhvDvDluT6oiya+GFzAh5wtfB7G8D4=; b=uks2duSw/rgzSVa0Wy9QZMX4eX1UZD/ObNuA0OnGaaSL7ufLwU0SBIJw9OD0RYE+im F9mq/Mev8cTvLquRvwj2voJAknZZ6Rizl+z88koWxj7QBTEUi/MHm70wV1uWqOSAOx71 S2MPnu0j1qpAzGpT5yXbQ54Ly8AJuHhl8s+dSiSgr/quGRfW9M3zOUV4rvxvn50hjjLw iE7fZl22f3ozNklSzh2IdCUjqnZcL+Uu11Y2HA/xVzNYbiVerky32y2LM6TDiDYZ7v0p ELAfQbMau+DYi8OYY/9vvbgGi4A7WMaHtJu+ghntJrNVc/sqTPTDuDpYrO9JlFyO/wAM +ntA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=788XxievPXArbKhvDvDluT6oiya+GFzAh5wtfB7G8D4=; b=dlfNis7LJ4IVeLGqqFmxYj65JoQacXrNWm1Alt6nZJ7C/Yfhj+1oXOCbS0r6/Z3Jl9 GgYd1ItVjQp0IdKNCukYU4DiqSkELz4u///yBKgR5Rd9xRtWDdlDKRFiKSn86ru6Wo4l TRxxNAgb6a1WBQ5cY4IZ5eFOZ1q27xuoeX1PC7UknjFnJf8c+NHUJCXIk4QL2NR0EtqI 0q3iBtArKYGc2FiIQg+55bhGEHVkq2rl7G2I73DRLnijR0jTVku0XVxP+vdm3WmCXSOS p5PhM2vt03EyQK9xOqf0hKlg5JZTyvIY/qFnvIPjoRv4Zsn+QjMSIRz4v68Jz0DZgmFP LgQw== X-Gm-Message-State: AOAM530Lw3fRB6M5jE8I/+gwck2tjNFtdIdcorvu4kMdWtsC5+YOiyDp 47jzdXuHlhOL8aber9rWIDafv9jJyKLvL5gYXuv3sNLR7AE= X-Received: by 2002:a05:6402:3074:: with SMTP id bs20mr13697948edb.365.1607205216408; Sat, 05 Dec 2020 13:53:36 -0800 (PST) MIME-Version: 1.0 References: <20201201190100.17831-1-aouledameur@baylibre.com> <20201201190100.17831-2-aouledameur@baylibre.com> In-Reply-To: <20201201190100.17831-2-aouledameur@baylibre.com> From: Martin Blumenstingl Date: Sat, 5 Dec 2020 22:53:25 +0100 Message-ID: Subject: Re: [PATCH v2 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use To: Amjad Ouled-Ameur Cc: Kevin Hilman , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Zabel , linux-amlogic@lists.infradead.org, Jerome Brunet Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2020 at 8:01 PM Amjad Ouled-Ameur wrote: > > Use reset_control_rearm() call if an error occurs in case > phy_meson_gxl_usb2_init() fails after reset() has been called ; or in case > phy_meson_gxl_usb2_exit() is called i.e the resource is no longer used > and the reset line may be triggered again by other devices. > > reset_control_rearm() keeps use of triggered_count sane in the reset > framework. Therefore, use of reset_control_reset() on shared reset line > should be balanced with reset_control_rearm(). > > Signed-off-by: Amjad Ouled-Ameur > Reported-by: Jerome Brunet Reviewed-by: Martin Blumenstingl