Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1552654pxu; Sat, 5 Dec 2020 22:57:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzLNNGRYJhq3Zrf+UOK4+iq1jgMhvdKdYzP5x+jmmJDVG853Beza0ahgxflr9XvIO4eQ0JV X-Received: by 2002:a50:a6c9:: with SMTP id f9mr14707633edc.158.1607237826662; Sat, 05 Dec 2020 22:57:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607237826; cv=none; d=google.com; s=arc-20160816; b=aAVhSFBbwDvOcNj5cUjPYlmP0Cxi+oVJZecmsI6mcn7Cv3usvbRznwGy6sk1Wi/N0e OczCUhkKQvrLubpM8i0rk9pzDWWJ3kg8tw0I0vHLW1p1JWU9wKwPYGlah3Yp/0vxf9qE pSusfi/2Y/Ywgl6VnrvrwYXf6K0M7IvWSuAu4bkx8lom9kGXB/P7R30IFmnSqs79AhQp U1Q0Qt0VC9eIu0T74Y5dRY1w1ZFoh50YA0YgooXJW9XT6xpqvXXOniZIJfaU3efmoJml Jrry47zH1fdfHzfumKfxysCUff5iKULa0frpbrSuewwcyQfT00qz76f0bwTdZScvnkFZ Pw6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=RZ4Klcv7MjQhrlFlFICUWdmtXPcLQdJtQcK1nc/RQJo=; b=Z2OhFTo8D1KQ7w7n4nZDtcu2X3BNPQFico+s5U1gE10lYErF6YGZW8uONJ6tes+fVA a0p12GDvHYm4qp/eJaRrhVs/JktX8ZqlHeFP/AzQsVFIkf0XT6ECAoZAcvdeQOn4RC/8 gxkBxZwj/uCpajBi2F809dwySrwGNCffOAWQmWeM4t4Iirpv1lljeQ0YBWV5i4DJn3sI IpBCPfy1aZXnxiacrWOg5tj4iQ9VTDNveq7B+KGEHf+HXGZRuntKEQklbBRZJKZ+ox5O jDxifNdtPcULgi/qBIqycQ/amfr64ASwo6PNBG2/aIUHSm6g9NU7GoMu5j7zh4FRoOwK Nn+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=WGhbsaYv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v22si6157453edt.77.2020.12.05.22.56.43; Sat, 05 Dec 2020 22:57:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=WGhbsaYv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725879AbgLFGzI (ORCPT + 99 others); Sun, 6 Dec 2020 01:55:08 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:16829 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbgLFGzI (ORCPT ); Sun, 6 Dec 2020 01:55:08 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sat, 05 Dec 2020 22:54:27 -0800 Received: from mtl-vdi-166.wap.labs.mlnx (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 6 Dec 2020 06:54:26 +0000 Date: Sun, 6 Dec 2020 08:54:22 +0200 From: Eli Cohen To: Jason Wang CC: "Michael S. Tsirkin" , Cindy Lu , , Subject: Re: [PATCH] vdpa/mlx5: Use random MAC for the vdpa net instance Message-ID: <20201206065422.GA161813@mtl-vdi-166.wap.labs.mlnx> References: <20201202055714.GA224423@mtl-vdi-166.wap.labs.mlnx> <20201202041518-mutt-send-email-mst@kernel.org> <3e32ef6d-83c9-5866-30e5-f6eeacd5044d@redhat.com> <20201202165932-mutt-send-email-mst@kernel.org> <20201203064928.GA27404@mtl-vdi-166.wap.labs.mlnx> <20201203054330-mutt-send-email-mst@kernel.org> <20201203120929.GA38007@mtl-vdi-166.wap.labs.mlnx> <20201203071414-mutt-send-email-mst@kernel.org> <20201203122421.GB38007@mtl-vdi-166.wap.labs.mlnx> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13) X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1607237667; bh=RZ4Klcv7MjQhrlFlFICUWdmtXPcLQdJtQcK1nc/RQJo=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To:User-Agent:X-Originating-IP:X-ClientProxiedBy; b=WGhbsaYv64TkjEFiy+xCBZahO2JoDGtylJcvuQEKdC/tTyowhPGK7dojaxb46iu+C 6QFRbINr2wG075TrcSSBFpbKzUsBxgFoezM5qy7t8+YrsGDM/qWS+KlLsrOzsBO/zE 26fMc6cLqh7ffBLyS2jeCFxgs6/6IW7k9ULRBciyW3yaiDJiXzCJzTPZuHQveXy/TS 2kTwJbkFBzWFWAFEb28NVVRG6lv4NNO/An7nbMkWG+3S0ojRcOcPca1UOgGmDRCW9i jM/NQL27Ps//uIISP9JHcsTKFiSN1lAr15gx0r5hAMa+OuKzfi/dvwWQQHEHExt1lJ 7uUmJUYpDLm1g== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 04, 2020 at 10:53:28AM +0800, Jason Wang wrote: >=20 > On 2020/12/3 =E4=B8=8B=E5=8D=888:24, Eli Cohen wrote: > > > > It is mentioned in Parav's patchset that this will be coming in a > > > > subsequent patch to his vdpa tool. > > > So I think kernel has two options: > > > - require a mac when device is created, we supply it to guest > > Yes, the driver should always set VIRTIO_NET_F_MAC and provide a MAC - > > either random or whatever configured using the vdpa too. >=20 >=20 > A questions here, I think current mlx5 vdpa works for VF only. So I think > the VF should have a given MAC? If yes, can we use that MAC? >=20 The MAC assigned to VF is by the NIC implementation. Both ther regular NIC driver and the VDPA implementation can co-exist so we can't use the NIC's MAC for VDPA. We want to steer traffic based on its destination MAC address to either VDPA or regular NIC.