Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1601120pxu; Sun, 6 Dec 2020 01:04:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJw3iApmBZM0ec3cwKeIYxvYfUtHt9pDuzeOI+8clmAPFEGhIzAIsBd2jjy3Lzxnr3dsgB77 X-Received: by 2002:a17:906:710b:: with SMTP id x11mr14931376ejj.433.1607245492755; Sun, 06 Dec 2020 01:04:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607245492; cv=none; d=google.com; s=arc-20160816; b=zw5GHpLER8wcaOl9qMALTy5avIYOy2hlXPNHQTbwEHkS/9ne5B8gHEEvUAJRfgmih/ TUez6fnzEUIicKUQ31QqOOLkt23s52bnoW3fqMBeDXCMPZ5CrhEATzA01rTB6+PeRgAc A8NW91w6WZ0QtzoAR4rxHd7W7rc2NrivQuLltuHiTiZxJ+uTKUKym4wEKc85jQfXjWBN 2fUJvXgcEaGyzIqqSqQa+WLAagmsiM+CvBYey/cqo7tBPMi0yJEkAOks99+auKIFJV7E eU12yagMV+uLeH+8Ja9B/zwn7mlV7/09VeFEmsPEotMc+D7P1exBkH7Lh7bUjl9FiB1C VeaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:dkim-signature; bh=Hwo2nxex8p4mqzo/Jjxy83IknfLVqgCAaC9OtpFj27I=; b=QcXsXtivMQQ6bsbLOWrkcEQPhHYlHvWmOpJ+mqFKLLmEm81KosO3fNJKe/C6pHcT6J zkznjbnkcHqOEJzIR0D1TPeaRd5xPtk4TIFDH670PiwIiXBDs4jiOEje5jDWWpqW+SjN W9mbsDpjqDt7QF/ZgNY2PghrzYjBix7F9Uok/2udvvHifv/TW7VnAbZsHx0pEooSrf8N PP7ES7Y1KSrzxqv9a6l1+PRypqo43PSPqKwntdg8Oyg68RKq0KX6ijJn4HJ1LgA+oq/M RjaByrGpHlA/71nXsKhsNhkh84/lkAGdhdr1HcJ+6ZG5YeKIoYRCs7xJzYgPO2jnAPKl 8pvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=au7Hr505; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si6190052edf.467.2020.12.06.01.04.29; Sun, 06 Dec 2020 01:04:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=au7Hr505; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726342AbgLFJCv (ORCPT + 99 others); Sun, 6 Dec 2020 04:02:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:32922 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725767AbgLFJCp (ORCPT ); Sun, 6 Dec 2020 04:02:45 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607245318; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Hwo2nxex8p4mqzo/Jjxy83IknfLVqgCAaC9OtpFj27I=; b=au7Hr505avGpJvdS9zMayF+Af4pMfFXT4OzGYlpCFDvVPRQl0zIf7/YTOnh3DXHNyVS32U VL3QLdQ8/Bo3qbYyU+LLMH/E9m/mDNzC7r3yL+DgiPxdHteX/ddLZOQkcBgSke87HxRdYu chLKmleFGOIkMOYloiQTZmDiZAIxOJ4= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EE9C2AC55; Sun, 6 Dec 2020 09:01:57 +0000 (UTC) Subject: Re: [PATCH v2 1/8] lib/find_bit.c: Add find_last_zero_bit To: Yun Levi , Greg KH Cc: Andrew Morton , Yury Norov , Andy Shevchenko , richard.weiyang@linux.alibaba.com, christian.brauner@ubuntu.com, Arnd Bergmann , Josh Poimboeuf , rdunlap@infradead.org, masahiroy@kernel.org, peterz@infradead.org, peter.enderborg@sony.com, krzk@kernel.org, Brendan Higgins , Kees Cook , broonie@kernel.org, matti.vaittinen@fi.rohmeurope.com, mhiramat@kernel.org, jpa@git.mail.kapsi.fi, nivedita@alum.mit.edu, Alexander Potapenko , orson.zhai@unisoc.com, Takahiro Akashi , clm@fb.com, Josef Bacik , dsterba@suse.com, dushistov@mail.ru, Linux Kernel Mailing List , linux-arch@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20201206064624.GA5871@ubuntu> From: Nikolay Borisov Autocrypt: addr=nborisov@suse.com; prefer-encrypt=mutual; keydata= mQINBFiKBz4BEADNHZmqwhuN6EAzXj9SpPpH/nSSP8YgfwoOqwrP+JR4pIqRK0AWWeWCSwmZ T7g+RbfPFlmQp+EwFWOtABXlKC54zgSf+uulGwx5JAUFVUIRBmnHOYi/lUiE0yhpnb1KCA7f u/W+DkwGerXqhhe9TvQoGwgCKNfzFPZoM+gZrm+kWv03QLUCr210n4cwaCPJ0Nr9Z3c582xc bCUVbsjt7BN0CFa2BByulrx5xD9sDAYIqfLCcZetAqsTRGxM7LD0kh5WlKzOeAXj5r8DOrU2 GdZS33uKZI/kZJZVytSmZpswDsKhnGzRN1BANGP8sC+WD4eRXajOmNh2HL4P+meO1TlM3GLl EQd2shHFY0qjEo7wxKZI1RyZZ5AgJnSmehrPCyuIyVY210CbMaIKHUIsTqRgY5GaNME24w7h TyyVCy2qAM8fLJ4Vw5bycM/u5xfWm7gyTb9V1TkZ3o1MTrEsrcqFiRrBY94Rs0oQkZvunqia c+NprYSaOG1Cta14o94eMH271Kka/reEwSZkC7T+o9hZ4zi2CcLcY0DXj0qdId7vUKSJjEep c++s8ncFekh1MPhkOgNj8pk17OAESanmDwksmzh1j12lgA5lTFPrJeRNu6/isC2zyZhTwMWs k3LkcTa8ZXxh0RfWAqgx/ogKPk4ZxOXQEZetkEyTFghbRH2BIwARAQABtCNOaWtvbGF5IEJv cmlzb3YgPG5ib3Jpc292QHN1c2UuY29tPokCOAQTAQIAIgUCWIo48QIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQcb6CRuU/KFc0eg/9GLD3wTQz9iZHMFbjiqTCitD7B6dTLV1C ddZVlC8Hm/TophPts1bWZORAmYIihHHI1EIF19+bfIr46pvfTu0yFrJDLOADMDH+Ufzsfy2v HSqqWV/nOSWGXzh8bgg/ncLwrIdEwBQBN9SDS6aqsglagvwFD91UCg/TshLlRxD5BOnuzfzI Leyx2c6YmH7Oa1R4MX9Jo79SaKwdHt2yRN3SochVtxCyafDlZsE/efp21pMiaK1HoCOZTBp5 VzrIP85GATh18pN7YR9CuPxxN0V6IzT7IlhS4Jgj0NXh6vi1DlmKspr+FOevu4RVXqqcNTSS E2rycB2v6cttH21UUdu/0FtMBKh+rv8+yD49FxMYnTi1jwVzr208vDdRU2v7Ij/TxYt/v4O8 V+jNRKy5Fevca/1xroQBICXsNoFLr10X5IjmhAhqIH8Atpz/89ItS3+HWuE4BHB6RRLM0gy8 T7rN6ja+KegOGikp/VTwBlszhvfLhyoyjXI44Tf3oLSFM+8+qG3B7MNBHOt60CQlMkq0fGXd mm4xENl/SSeHsiomdveeq7cNGpHi6i6ntZK33XJLwvyf00PD7tip/GUj0Dic/ZUsoPSTF/mG EpuQiUZs8X2xjK/AS/l3wa4Kz2tlcOKSKpIpna7V1+CMNkNzaCOlbv7QwprAerKYywPCoOSC 7P25Ag0EWIoHPgEQAMiUqvRBZNvPvki34O/dcTodvLSyOmK/MMBDrzN8Cnk302XfnGlW/YAQ csMWISKKSpStc6tmD+2Y0z9WjyRqFr3EGfH1RXSv9Z1vmfPzU42jsdZn667UxrRcVQXUgoKg QYx055Q2FdUeaZSaivoIBD9WtJq/66UPXRRr4H/+Y5FaUZx+gWNGmBT6a0S/GQnHb9g3nonD jmDKGw+YO4P6aEMxyy3k9PstaoiyBXnzQASzdOi39BgWQuZfIQjN0aW+Dm8kOAfT5i/yk59h VV6v3NLHBjHVw9kHli3jwvsizIX9X2W8tb1SefaVxqvqO1132AO8V9CbE1DcVT8fzICvGi42 FoV/k0QOGwq+LmLf0t04Q0csEl+h69ZcqeBSQcIMm/Ir+NorfCr6HjrB6lW7giBkQl6hhomn l1mtDP6MTdbyYzEiBFcwQD4terc7S/8ELRRybWQHQp7sxQM/Lnuhs77MgY/e6c5AVWnMKd/z MKm4ru7A8+8gdHeydrRQSWDaVbfy3Hup0Ia76J9FaolnjB8YLUOJPdhI2vbvNCQ2ipxw3Y3c KhVIpGYqwdvFIiz0Fej7wnJICIrpJs/+XLQHyqcmERn3s/iWwBpeogrx2Lf8AGezqnv9woq7 OSoWlwXDJiUdaqPEB/HmGfqoRRN20jx+OOvuaBMPAPb+aKJyle8zABEBAAGJAh8EGAECAAkF AliKBz4CGwwACgkQcb6CRuU/KFdacg/+M3V3Ti9JYZEiIyVhqs+yHb6NMI1R0kkAmzsGQ1jU zSQUz9AVMR6T7v2fIETTT/f5Oout0+Hi9cY8uLpk8CWno9V9eR/B7Ifs2pAA8lh2nW43FFwp IDiSuDbH6oTLmiGCB206IvSuaQCp1fed8U6yuqGFcnf0ZpJm/sILG2ECdFK9RYnMIaeqlNQm iZicBY2lmlYFBEaMXHoy+K7nbOuizPWdUKoKHq+tmZ3iA+qL5s6Qlm4trH28/fPpFuOmgP8P K+7LpYLNSl1oQUr+WlqilPAuLcCo5Vdl7M7VFLMq4xxY/dY99aZx0ZJQYFx0w/6UkbDdFLzN upT7NIN68lZRucImffiWyN7CjH23X3Tni8bS9ubo7OON68NbPz1YIaYaHmnVQCjDyDXkQoKC R82Vf9mf5slj0Vlpf+/Wpsv/TH8X32ajva37oEQTkWNMsDxyw3aPSps6MaMafcN7k60y2Wk/ TCiLsRHFfMHFY6/lq/c0ZdOsGjgpIK0G0z6et9YU6MaPuKwNY4kBdjPNBwHreucrQVUdqRRm RcxmGC6ohvpqVGfhT48ZPZKZEWM+tZky0mO7bhZYxMXyVjBn4EoNTsXy1et9Y1dU3HVJ8fod 5UqrNrzIQFbdeM0/JqSLrtlTcXKJ7cYFa9ZM2AP7UIN9n1UWxq+OPY9YMOewVfYtL8M= Message-ID: <4e339fb4-adae-4c28-a40b-986b5e73fd0d@suse.com> Date: Sun, 6 Dec 2020 11:01:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6.12.20 г. 10:56 ч., Yun Levi wrote: >> This, and the change above this, are not related to this patch so you >> might not want to include them. > >> Also, why is this patch series even needed? I don't see a justification >> for it anywhere, only "what" this patch is, not "why". > > I think the find_last_zero_bit will help to improve in > 7th patch's change and It can be used in the future. > But if my thinking is bad.. Please let me know.. > > Thanks. > Levi. > btrfs' free space cache v1 is going to be removed some time in the future so introducing kernel-wide change just for its own sake is a bit premature. Also do you have measurements showing it indeed improves performances?