Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp1619621pxu; Sun, 6 Dec 2020 01:48:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJyy7TIRMEiMohUCo2gmss94PB/FHf5dYdGO3UvtuO7fiLxwkkMDk+ANFleLMg6G33HUe5ag X-Received: by 2002:a17:906:4d17:: with SMTP id r23mr861056eju.87.1607248096784; Sun, 06 Dec 2020 01:48:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607248096; cv=none; d=google.com; s=arc-20160816; b=Vmn6dzfp4Rc9igzqwoF3Z3e8Rn5ojZTMeBiAmzydC5oLn+WSKuPUGzJ53thRbOvxgC ccvXqx1yvZuy4N3yfq2woYOb0V2T4od2729FDWWuYBjuwRctvhdcf6bOo6ipmnwwHSVB oBz4OOjz5oaSx8rSsDSoqnQeqKjpPKp9CZrT5Ike7Nhk6zd95tpFaBuW5S9Rm3NEMcZQ wWwk9onjxZf5B1MwQ6VUJDUN9A7gWsPl6UyfbnJ8K0OBnlzbKxWd+TO6euvIDyzeUAwB snaeoX6zw3TSH2apf/MrOWaqhAqeeu30Ek0LClqUDIQluiydKX4srKU1kjHMVBaOo0vL AJkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=95XrULo2oCHTUekAIwx7LFGRSbJERWUGKicRwoLsg6w=; b=eWXzfNTAFSkJFByQNWuDbilUdbExVo7Jjx21EDBS61YvzcKbiTExEROuOYo/JtDThy N9gwJy+vOX1Bv/S+OLONG9wCZEwo16dy+mziXuWWqd9sKlyOootGhnrGTMzIVRn0JRcx bM5kg5PyXmD0QqzwyrcLy3SVlcPF+QHbu17EsKsZHQf99kj3v9gDsa7aAPwZdrHMW8tl BQwI/sInWvqIBSfdVOng7AKHK5t4YDqWtLJa7ci2ZEesBEFAfZGcOEiCu85/2KgCcOxR S0xvax47v7HIgCpsIdhDkPUCkUP6zONe6kGU85qKJ5Ih/T5BF7LPaSLLMEM7QE6RfD/O pZJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=u9w6crCa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a15si5240295eju.388.2020.12.06.01.47.52; Sun, 06 Dec 2020 01:48:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=u9w6crCa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726181AbgLFJp2 (ORCPT + 99 others); Sun, 6 Dec 2020 04:45:28 -0500 Received: from mail.kernel.org ([198.145.29.99]:37466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbgLFJp2 (ORCPT ); Sun, 6 Dec 2020 04:45:28 -0500 Date: Sun, 6 Dec 2020 10:46:00 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607247887; bh=AdMCsFUCPvhREyGXJQ7Ie8nrtYsSWzDA4PhmNXIg4sI=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=u9w6crCanNLt4Fnivds3AWGLYLbRklR7BnOoSrQTTPe4Du2eJkHAZqA4xg48E8iSV gffPqa2BFmiXs+wyCz/H7QeivL3Bq8PyIX/pkzRmVXRiJphgx+n1BUXolRHXrCIlGk nU8Ildv55S5doKxhRyrgNTiLc6pTfS3OSND+wbjo= From: Greg Kroah-Hartman To: dann frazier Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ard Biesheuvel , Matthias Kaehlcke , Herbert Xu , Nathan Chancellor Subject: Re: [PATCH 4.4 17/70] crypto: arm64/sha - avoid non-standard inline asm tricks Message-ID: References: <20181126105046.722096341@linuxfoundation.org> <20181126105048.515352194@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 05, 2020 at 01:39:28PM -0700, dann frazier wrote: > On Mon, Nov 23, 2020 at 01:49:07PM -0700, dann frazier wrote: > > On Mon, Nov 26, 2018 at 11:50:32AM +0100, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > fyi, I bisected a regression down to this commit. This apparently > > causes an ADR_PREL_PG_HI21 relocation to be added to the sha{1,2}_ce > > modules. Back in 4.4 ADR_PREL_PG_HI21 relocations were forbidden if > > built with CONFIG_ARM64_ERRATUM_843419=y, so now the sha{1,2}_ce modules > > fail to load: > > > > [ 37.866250] module sha1_ce: unsupported RELA relocation: 275 > > > > Looks like it should be an issue for 4.14.y as well, but I haven't yet > > tested it. > > This regression appears to be limited to 4.4.y. I didn't find it when > testing 4.9.y, and a 2nd bisection determined that it is because > 4.9.y+ also contains a backport of commit 41c066f ("arm64: assembler: > make adr_l work in modules under KASLR"). That was pulled from 4.4.y > because it caused a build failure: > > https://www.spinics.net/lists/stable/msg179709.html > > Shall I submit a revert of this patch for 4.4.y, or is it worth trying > to get a backport of 41c066f to work? Which ever you think would be best is fine. thanks, greg k-h