Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v15 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308,
 RK2928 and others
From:   Johan Jonker <jbx6244@gmail.com>
To:     Yifeng Zhao <yifeng.zhao@rock-chips.com>,
        miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
        robh+dt@kernel.org
Cc:     devicetree@vger.kernel.org, heiko@sntech.de,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org
References: <20201130100031.22083-1-yifeng.zhao@rock-chips.com>
 <20201130100031.22083-3-yifeng.zhao@rock-chips.com>
 <0abf1dbd-13bb-cd92-907c-849f05ea887c@gmail.com>
Message-ID: <259fe1ce-6bcb-3a26-493d-87bbd2eaff5e@gmail.com>
Date:   Sun, 6 Dec 2020 15:10:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <0abf1dbd-13bb-cd92-907c-849f05ea887c@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Yifeng,

Meanwhile, could you post a RFC version for Uboot based on this version
plus comments, so people can test the whole process from programming,
booting and kernel?

On 11/30/20 1:49 PM, Johan Jonker wrote:
> Hi,
> 
> Looks good to me.
> Do the maintainers or someone else have any major issues?
> Could Miquel indicate if a version 16 must be send for that 'ret'
> variable alone or is it OK now?
> 
> 
> On 11/30/20 11:00 AM, Yifeng Zhao wrote:
>> This driver supports Rockchip NFC (NAND Flash Controller) found on RK3308,
>> RK2928, RKPX30, RV1108 and other SOCs. The driver has been tested using
>> 8-bit NAND interface on the ARM based RK3308 platform.

[..]

>> +/**
>> + * struct rk_ecc_cnt_status: represent a ecc status data.

represent the ECC status data.

>> + * @err_flag_bit: error flag bit index at register.
>> + * @low: ECC count low bit index at register.
>> + * @low_mask: mask bit.
>> + * @low_bn: ECC count low bit number.
>> + * @high: ECC count high bit index at register.
>> + * @high_mask: mask bit
>> + */