Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 6 Dec 2020 14:33:33 +0000 (GMT)
From:   "Maciej W. Rozycki" <macro@linux-mips.org>
To:     Anders Roxell <anders.roxell@linaro.org>
cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        natechancellor@gmail.com, ndesaulniers@google.com,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        clang-built-linux@googlegroups.com
Subject: Re: [PATCH] mips: lib: uncached: fix uninitialized variable 'sp'
In-Reply-To: <alpine.LFD.2.21.2012060915460.656242@eddie.linux-mips.org>
Message-ID: <alpine.LFD.2.21.2012061431190.656242@eddie.linux-mips.org>
References: <20201127083938.2666770-1-anders.roxell@linaro.org> <alpine.LFD.2.21.2012060915460.656242@eddie.linux-mips.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 6 Dec 2020, Maciej W. Rozycki wrote:

>  I think this should be OK once the issues I mentioned here have been 
> addressed.

 Or alternatively making the variable global would possibly be a better 
fix as it would let the compiler decide if to waste another register to 
keep a copy of $sp.

  Maciej