Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "ohad@wizery.com" <ohad@wizery.com>,
        "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
        "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Richard Zhu <hongxing.zhu@nxp.com>
Subject: RE: [PATCH V3 3/7] remoteproc: imx_rproc: correct err message
Thread-Topic: [PATCH V3 3/7] remoteproc: imx_rproc: correct err message
Thread-Index: AQHWygzmKuzGPnaAGEqtlRtv96WXwannpliAgANBImA=
Date:   Mon, 7 Dec 2020 02:08:29 +0000
Message-ID: <DB6PR0402MB2760019ACC7558DC48BF98C288CE0@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <20201204074036.23870-1-peng.fan@oss.nxp.com>
 <20201204074036.23870-4-peng.fan@oss.nxp.com> <X8rTnx/lQIxcuEXf@builder.lan>
In-Reply-To: <X8rTnx/lQIxcuEXf@builder.lan>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a9d187d0-c581-46b5-76bd-08d89a54fd85
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2020 02:08:29.3598
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vE38EeJPHfeEzL+jmGaNd+x0+j3cMrx1IoLERFIiqQcNFYfxHcVsIob0QsGgLvK6J5YqZahjATioF7OEKjQlsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4633
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH V3 3/7] remoteproc: imx_rproc: correct err message
>=20
> On Fri 04 Dec 01:40 CST 2020, Peng Fan (OSS) wrote:
>=20
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > It is using devm_ioremap, so not devm_ioremap_resource. Correct the
> > error message and print out sa/size.
> >
> > Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  drivers/remoteproc/imx_rproc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index d1abb253b499..aa5fbd0c7768
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -270,7 +270,7 @@ static int imx_rproc_addr_init(struct imx_rproc
> *priv,
> >  		priv->mem[b].cpu_addr =3D devm_ioremap(&pdev->dev,
> >  						     att->sa, att->size);
> >  		if (!priv->mem[b].cpu_addr) {
> > -			dev_err(dev, "devm_ioremap_resource failed\n");
> > +			dev_err(dev, "devm_ioremap failed\n");
>=20
> I would prefer if this was expanded to a proper sentence, and I really li=
ke the
> second part of the commit message to be included in the change.
> So something like:
>=20
> 			dev_err(dev, "failed to remap %#x bytes from %#x\n",
> 				att->size, att->sa);
>=20
>=20
> And similarly below if mapping a memory-region fails.

ok, fix in v4.

Thanks,
Peng.

>=20
> Thanks,
> Bjorn
>=20
> >  			return -ENOMEM;
> >  		}
> >  		priv->mem[b].sys_addr =3D att->sa;
> > --
> > 2.28.0
> >