Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 0/5] Some cleanups and improvements for blk-iocost
To:     axboe@kernel.dk, tj@kernel.org
Cc:     baolin.wang7@gmail.com, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1606378475.git.baolin.wang@linux.alibaba.com>
From:   Baolin Wang <baolin.wang@linux.alibaba.com>
Message-ID: <ef1ebb96-3e2b-44e9-f7dd-463124921747@linux.alibaba.com>
Date:   Mon, 7 Dec 2020 15:19:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <cover.1606378475.git.baolin.wang@linux.alibaba.com>
Content-Type: text/plain; charset=gbk; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jens,

> Hi,
> 
> This patch set did some cleanups and improvements for blk-iocost, and
> no big functional changes. Please help to review. Thanks.
> 
> Changes from v1:
>   - Add acked-by tag from Tejun.
>   - Drop 2 unnecessary patches.
>   - Move the related variable declarations inside the block together
>   with the code in patch 3.
>   - Move the commit_weights() into ioc_check_iocgs().
>   - Move more related logics of adjusting base vrate into the
>   ioc_adjust_base_vrate().
>   - Rename the new functions.

Could you take this patch set if no objection from your side? Thanks.

> 
> Baolin Wang (5):
>    blk-iocost: Fix some typos in comments
>    blk-iocost: Remove unnecessary advance declaration
>    blk-iocost: Move the usage ratio calculation to the correct place
>    blk-iocost: Factor out the active iocgs' state check into a separate
>      function
>    blk-iocost: Factor out the base vrate change into a separate function
> 
>   block/blk-iocost.c | 251 +++++++++++++++++++++++++++++------------------------
>   1 file changed, 137 insertions(+), 114 deletions(-)
>