Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201205042626.1113600-1-daeho43@gmail.com> <c3c41d53-2a99-17a2-223a-3d674613a417@huawei.com>
In-Reply-To: <c3c41d53-2a99-17a2-223a-3d674613a417@huawei.com>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Mon, 7 Dec 2020 16:28:28 +0900
Message-ID: <CACOAw_zwbmYHbUVUmzGMci9SaSVSrP8NXXavHBSSLxbAEOrMcw@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: fix race of pending_pages in decompression
To:     Chao Yu <yuchao0@huawei.com>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        Daeho Jeong <daehojeong@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> It looks like it will be better to move this into merge condition?
>
>                 if (bio && (!page_is_mergeable(sbi, bio,
>                                         *last_block_in_bio, blkaddr) ||
>                     !f2fs_crypt_mergeable_bio(bio, inode, page->index, NULL) ||
>                         f2fs_verify_mergeable_bio())) {
>

I tried this for the first time, but it requires unnecessary checks
within the compression cluster.
I wanted to just check one time in the beginning of the cluster.
What do you think?