Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ipo5ixYfj9nGb3NCK9rbALJM23GHyagz31rybyt4+7cJkiX6LGJRkhSEAT+Rd9gRMAHNpzua47
 aX70nZEYtUwnc9aY/sgEeT/uEEcHitA7x3czkadfdOjYLnNYve/B1LmlzkpTdSmAK8wucdcuuN
 ulTHNbyVMmF4pvQhm14A+MQkdexr4DKxh2/mCy16n0hxn7/1/RX/zMcU5UMr9IazFEviBn0wlY
 V0DedzoxcbMuUQv3DewrtcWfqHb9jvQuX1Zv15wTEzNoR9PNvMF9Xj8s69DOdeS7SPIW4HMoP1
 EKQ=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>
Subject: RE: [PATCH v1 1/3] scsi: ufs: Distinguish between query REQ and query
 RSP in query trace
Thread-Topic: [PATCH v1 1/3] scsi: ufs: Distinguish between query REQ and
 query RSP in query trace
Thread-Index: AQHWy+7UoD6YMCkFLkq2lSN/rWGYaqnrQMtA
Date:   Mon, 7 Dec 2020 07:45:41 +0000
Message-ID: <DM6PR04MB6575E8A098E324E2061C793FFCCE0@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201206164226.6595-1-huobean@gmail.com>
 <20201206164226.6595-2-huobean@gmail.com>
In-Reply-To: <20201206164226.6595-2-huobean@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 97439c39-4342-4f50-800f-08d89a8418c6
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2020 07:45:41.4201
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zQDjpixXPtwKCgm7cEdVwlZROZaWK9/uCGcAff+s0+sb0P3GPcI2SSSx5tvkosCZR13WgQUM/0DRPIZDKyPL9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5947
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> From: Bean Huo <beanhuo@micron.com>
>=20
> Currently, in the query completion trace print,  since we use
> hba->lrb[tag].ucd_req_ptr and didn't differentiate UPIU between
> request and response, thus header and transaction-specific field
> in UPIU printed by query trace are identical. This is not very
> practical. As below:
>=20
> query_send: HDR:16 00 00 0e 00 81 00 00 00 00 00 00, CDB:06 0e 03 00 00 0=
0 00
> 00 00 00 00 00 00 00 00 00
> query_complete: HDR:16 00 00 0e 00 81 00 00 00 00 00 00, CDB:06 0e 03 00 =
00
> 00 00 00 00 00 00 00 00 00 00 00
>=20
> For the failure analysis, we want to understand the real response
> reported by the UFS device, however, the current query trace tells
> us nothing. After this patch, the query trace on the query_send, and
> the above a pair of query_send and query_complete will be:
>=20
> query_send: HDR:16 00 00 0e 00 81 00 00 00 00 00 00, CDB:06 0e 03 00 00 0=
0 00
> 00 00 00 00 00 00 00 00 00
> ufshcd_upiu: HDR:36 00 00 0e 00 81 00 00 00 00 00 00, CDB:06 0e 03 00 00 =
00 00
> 00 00 00 00 01 00 00 00 00
>=20
> Signed-off-by: Bean Huo <beanhuo@micron.com>
Acked-by: Avri Altman <avri.altman@wdc.com>

But you need to change the complete string so not to break the current pars=
ers.
I would also pass to ufshcd_add_query_upiu_trace the struct utp_upiu_req *,=
=20
so no comparison is needed.

Thanks,
Avri

> ---
>  drivers/scsi/ufs/ufshcd.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index ceb562accc39..e10de94adb3f 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -321,9 +321,15 @@ static void ufshcd_add_cmd_upiu_trace(struct
> ufs_hba *hba, unsigned int tag,
>  static void ufshcd_add_query_upiu_trace(struct ufs_hba *hba, unsigned in=
t
> tag,
>                 const char *str)
>  {
> -       struct utp_upiu_req *rq =3D hba->lrb[tag].ucd_req_ptr;
> +       struct utp_upiu_req *rq_rsp;
> +
> +       if (!strcmp("query_send", str))
> +               rq_rsp =3D hba->lrb[tag].ucd_req_ptr;
> +       else
> +               rq_rsp =3D (struct utp_upiu_req *)hba->lrb[tag].ucd_rsp_p=
tr;
>=20
> -       trace_ufshcd_upiu(dev_name(hba->dev), str, &rq->header, &rq->qr);
> +       trace_ufshcd_upiu(dev_name(hba->dev), str, &rq_rsp->header,
> +                         &rq_rsp->qr);
>  }
>=20
>  static void ufshcd_add_tm_upiu_trace(struct ufs_hba *hba, unsigned int
> tag,
> --
> 2.17.1