Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 06 Dec 2020 23:38:50 -0800 (PST)
Message-Id: <20201206.233850.576775262589107523.davem@davemloft.net>
To:     tanhuazhong@huawei.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kuba@kernel.org, huangdaode@huawei.com, sfr@canb.auug.org.au
Subject: Re: [PATCH net] net: hns3: remove a misused pragma packed
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1607325625-29945-1-git-send-email-tanhuazhong@huawei.com>
References: <1607325625-29945-1-git-send-email-tanhuazhong@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

From: Huazhong Tan <tanhuazhong@huawei.com>
Date: Mon, 7 Dec 2020 15:20:25 +0800

> hclge_dbg_reg_info[] is defined as an array of packed structure
> accidentally. However, this array contains pointers, which are
> no longer aligned naturally, and cannot be relocated on PPC64.
> Hence, when compile-testing this driver on PPC64 with
> CONFIG_RELOCATABLE=y (e.g. PowerPC allyesconfig), there will be
> some warnings.
> 
> Since each field in structure hclge_qos_pri_map_cmd and
> hclge_dbg_bitmap_cmd is type u8, the pragma packed is unnecessary
> for these two structures as well, so remove the pragma packed in
> hclge_debugfs.h to fix this issue, and this increases
> hclge_dbg_reg_info[] by 4 bytes per entry.
> 
> Fixes: a582b78dfc33 ("net: hns3: code optimization for debugfs related to "dump reg"")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>

Applied, thank you.