Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: SjaOyJdEm3P7hNweJDUainsLzsf98Ho9/BQctpRY1K1bShEMR9yO+ey4KMKMecGia4MXuFdINK
 T45INQgaIzIHjxWShPSWBuANVh4D5tO61rslmHincB38bDyYSamdzoUEwL9ZqX2dclpIf837bA
 RTB9CVkF2I49NYo0u9a0dy7E/revN4SEC1tQ2PBOUJmx5UrDAkFPGKzHnBzTzXaTG/35fgvYtE
 AArdCLjaPIdSwmWZe7qjptGtRukPCNGuBzZjA+YHmd0SYvhOLyy/BRHzenV8pXIwHrs13ETAH0
 kTM=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>
Subject: RE: [PATCH v1 2/3] scsi: ufs: Distinguish between TM request UPIU and
 response UPIU in TM UPIU trace
Thread-Topic: [PATCH v1 2/3] scsi: ufs: Distinguish between TM request UPIU
 and response UPIU in TM UPIU trace
Thread-Index: AQHWy+7WlAKMNaTMjEeUciEKEXKoOanrQkmg
Date:   Mon, 7 Dec 2020 07:49:38 +0000
Message-ID: <DM6PR04MB6575F3AEE424287EF666A591FCCE0@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201206164226.6595-1-huobean@gmail.com>
 <20201206164226.6595-3-huobean@gmail.com>
In-Reply-To: <20201206164226.6595-3-huobean@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 45afe380-360c-4176-614f-08d89a84a5d1
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2020 07:49:38.0272
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rd9XiAv5zhSLVoNMWiz3+4Cj2104NIbV7MBEV97wyxZoKwIhzywDT30Izwek62aY97Q7vLIrud2IWlPNUmv6UQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0401MB3654
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
>=20
> From: Bean Huo <beanhuo@micron.com>
>=20
> Distinguish between TM request UPIU and response UPIU in TM UPIU trace,
> for the TM response, let TM UPIU trace print its TM response UPIU.
>=20
> Signed-off-by: Bean Huo <beanhuo@micron.com>
Acked-by: Avri Altman <avri.altman@wdc.com>

Again - same comment:
But you need to change the complete string so not to break the current pars=
ers.
I would also pass to the  struct utp_upiu_header *,
so no comparison is needed.

Thanks,
Avri

> ---
>  drivers/scsi/ufs/ufshcd.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index e10de94adb3f..29d7240a61bf 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -338,8 +338,12 @@ static void ufshcd_add_tm_upiu_trace(struct
> ufs_hba *hba, unsigned int tag,
>         int off =3D (int)tag - hba->nutrs;
>         struct utp_task_req_desc *descp =3D &hba->utmrdl_base_addr[off];
>=20
> -       trace_ufshcd_upiu(dev_name(hba->dev), str, &descp->req_header,
> -                       &descp->input_param1);
> +       if (!strcmp("tm_send", str))
> +               trace_ufshcd_upiu(dev_name(hba->dev), str, &descp-
> >req_header,
> +                                 &descp->input_param1);
> +       else
> +               trace_ufshcd_upiu(dev_name(hba->dev), str, &descp-
> >rsp_header,
> +                                 &descp->output_param1);
>  }
>=20
>  static void ufshcd_add_uic_command_trace(struct ufs_hba *hba,
> --
> 2.17.1