Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: fdtZIUKt+uxBSl5TV519mi5u9nPUupurDtREzoiW/fWOQ9NvTOZbJBavcWav0R8rh6+ihwj8b/
 7GRos+1BYS3uf7HUf1whl8i0jhTae4zTzcBnR019CDoarhGu0+LiFjj4pGESM4sRI/jPZCsdPT
 cllAqLRnP6IHi930rL77hTfpgns5+vK1/PmR0oWztznJ6gM6eFMCBHrgQc7Nl44xpTJCtzd50j
 SO7MG8BfZJ8/GiwE1ZA6FXUP1S02PnaHkMIrvpvaWgo9m2897ELgpFlvQx20cMwe7y74BmFKmF
 GQ8=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/3] scsi: ufs: Keep device active mode only
 fWriteBoosterBufferFlushDuringHibernate == 1
Thread-Topic: [PATCH v2 2/3] scsi: ufs: Keep device active mode only
 fWriteBoosterBufferFlushDuringHibernate == 1
Thread-Index: AQHWy7iCBBJB+/QbNEOT3LqFCSOQUanrRfZg
Date:   Mon, 7 Dec 2020 08:02:41 +0000
Message-ID: <DM6PR04MB6575AED736BE44CA8D4B8998FCCE0@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201206101335.3418-1-huobean@gmail.com>
 <20201206101335.3418-3-huobean@gmail.com>
In-Reply-To: <20201206101335.3418-3-huobean@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e9fea04-45fc-4da4-0027-08d89a8678e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2020 08:02:41.6737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ki6icQ25phd8qj1XqZuxzWcS/eEiymcC7aIrVPD0NBwvAr0gR2OPZzId3VJbs/t2+PhptI4rLmyaSxrEv0bsIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5020
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> According to the JEDEC UFS 3.1 Spec, If
> fWriteBoosterBufferFlushDuringHibernate
> is set to one, the device flushes the WriteBooster Buffer data automatica=
lly
> whenever the link enters the hibernate (HIBERN8) state. While the flushin=
g
> operation is in progress, the device should be kept in Active power mode.
> Currently, we set this flag during the UFSHCD probe stage, but we didn't =
deal
> with its programming failure. Even this failure is less likely to occur, =
but
> still it is possible.
> This patch is to add checkup of fWriteBoosterBufferFlushDuringHibernate
> setting,
> keep the device as "active power mode" only when this flag be successfull=
y
> set
> to 1.
>=20
> Fixes: 51dd905bd2f6 ("scsi: ufs: Fix WriteBooster flush during runtime
> suspend")
> Signed-off-by: Bean Huo <beanhuo@micron.com>
You've added the fixes tag, but my previous comment is still unanswered:
you are adding protection to a single device management command.
Why this command in particular?=20
What makes it so special that it needs this extra care?

Thanks,
Avri