Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2241290pxu; Mon, 7 Dec 2020 00:56:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJxooFgiMQE0CK3mJyk0SmV6EAofGIoLPf2YxIzapRa748FlfFC40JxLoFXPC4hkLu2dvOHM X-Received: by 2002:a17:906:3883:: with SMTP id q3mr17603956ejd.160.1607331399773; Mon, 07 Dec 2020 00:56:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607331399; cv=none; d=google.com; s=arc-20160816; b=TWLez5RCRSzF8odTjhWlnhMZo7VN3wWsdxBsX/VUtBeM6eLIqZM39Z90aZXPhqWoM7 g49WEbdD5Zkm1qva6YrLS/Rxt8/RpAA2GKjoG4YxK5zn3IlaxQHdB4PoLNN/mJb67t0e QBN4A6KFnvv8UMaNw9prkqUiW7SggxVW1xb4WS6mKWIcpNWQa2ejIfTqB5E4amEccpOt p1ZiNCWe3w0bGgiPxgYQtw5JbeD74UBEw0H0S0g78EEpj6Vrxn0ewt7Q8sHpHP3n/Bmo hKa6XO4lG8rtoAqN78KW1h0B6C+rpoh5YGwwG0n5bRYfruAdcLfXAuc0DSQvZwMISYPX FCSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=gktlC3Key3lXSzbUIGuLemDVm9H2ePTn7aVTjMDQFuE=; b=wqRkraunHIGPyjae2BUEayBTcLTEn60aQPRGEkQ8iyvvtQmjKGrOnhNXckyCViwTfK py1yoZrZl+fnQPMe2gPjiA3RTNIj3Hc0aA+5csQ+TRbU8uR+4oYgvb42L6CQqUZLO3no be4IE2zku4IxGN8jA4XWB4G2mjqpahELyr34m4QL+mRvKMjpX91bzz7guD7BUwn90H6j DRPd9GZscICs40nFDqpdTc+egzUoyPnDOzNE7L28m7hHhFgUwo6CjvbvVjiyDaMDRYmj Wavd+YiTBBRJe+Bm9WdPib74mzYqwl56j+eqjyvftqalehrKqpL04xpO/P+2rwTsA+2A jOwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DFI+nyf+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si7717611edv.437.2020.12.07.00.56.17; Mon, 07 Dec 2020 00:56:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DFI+nyf+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726416AbgLGIys (ORCPT + 99 others); Mon, 7 Dec 2020 03:54:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:34710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgLGIys (ORCPT ); Mon, 7 Dec 2020 03:54:48 -0500 X-Gm-Message-State: AOAM532bf0mTlIcQiqy8JRW8zlHdC3mrX2OzwzX3etiMlwCgC/irJDNe KfDHvi+YYd4aQ3JJSFSg+ngh+Ehra90zSPWC9pQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607331247; bh=gktlC3Key3lXSzbUIGuLemDVm9H2ePTn7aVTjMDQFuE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DFI+nyf+K475BNkwyXDokcxaGZTORl6vN4iYe5TO3AV5H0HeNN1sDglHXfsI//bnV oCJu+Q9GnKU12cNLQAbICZXBmwHRU/g2JOdHjvjcaGLCvyuGM6fXAuE1EtpJLJFRcd EjZc+Tot75mfEZBZMi+3W4x0MwZ2MlUQrUXQhELzHjq5J6aIofqHCM5siyq38Lcofs RlijJlWCXCAvP8Fjc0olhidpKysI6pUo/1oYYFUtHjYRun0k8HkB43r/PoipZ+CZrU 7N/pcvJLpcRcnUe8Lae3+06gvthYHo4zP+VucYy22o5dHbgO6JAkUV+sEM0Ruc1/qf /ntaycMoPBWww== X-Received: by 2002:aca:b809:: with SMTP id i9mr11642773oif.174.1607331246914; Mon, 07 Dec 2020 00:54:06 -0800 (PST) MIME-Version: 1.0 References: <20201203230955.1482058-1-arnd@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Mon, 7 Dec 2020 09:53:55 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kbuild: avoid static_assert for genksyms To: Masahiro Yamada Cc: Arnd Bergmann , Andrew Morton , Linux Kbuild mailing list , Michal Marek , Arnd Bergmann , stable , Kees Cook , Rikard Falkeborn , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 6 Dec 2020 at 03:49, Masahiro Yamada wrote: > > On Fri, Dec 4, 2020 at 8:10 AM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > genksyms does not know or care about the _Static_assert() built-in, > > and sometimes falls back to ignoring the later symbols, which causes > > undefined behavior such as > > > > WARNING: modpost: EXPORT symbol "ethtool_set_ethtool_phy_ops" [vmlinux] version generation failed, symbol will not be versioned. > > ld: net/ethtool/common.o: relocation R_AARCH64_ABS32 against `__crc_ethtool_set_ethtool_phy_ops' can not be used when making a shared object > > net/ethtool/common.o:(_ftrace_annotated_branch+0x0): dangerous relocation: unsupported relocation > > > > Redefine static_assert for genksyms to avoid that. > > > Please tell the CONFIG options needed to reproduce this. > I do not see it. > https://people.linaro.org/~ard.biesheuvel/randconfig-modversions-error