Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Dec 2020 11:32:30 +0100
From:   Christian Brauner <christian.brauner@ubuntu.com>
To:     Jann Horn <jannh@google.com>
Cc:     Oleg Nesterov <oleg@redhat.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH pidfd] signal: Add missing __user annotation to
 copy_siginfo_from_user_any
Message-ID: <20201207103230.inx52blkask3662j@wittgenstein>
References: <20201207000252.138564-1-jannh@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201207000252.138564-1-jannh@google.com>
Precedence: bulk

On Mon, Dec 07, 2020 at 01:02:52AM +0100, Jann Horn wrote:
> copy_siginfo_from_user_any() takes a userspace pointer as second
> argument; annotate the parameter type accordingly.
> 
> Signed-off-by: Jann Horn <jannh@google.com>
> ---
> I'm messing around with clang's version of __user annotation checking
> and it spotted this issue:
> 
> kernel/signal.c:3759:44: warning: casting to dereferenceable pointer removes 'noderef' attribute [-Wnoderef]
>                 ret = copy_siginfo_from_user_any(&kinfo, info);
>                                                          ^~~~
> Untracked cast to function pointer at kernel/signal.c:4294:26
> 
> 
> Christian, since this is pidfd code, can you take this through your tree?
> Or should I send this to akpm (or someone else)?

I'm picking it up now. :) Thanks!

Christian