Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Dec 2020 12:24:10 +0100
From:   Dominique Martinet <asmadeus@codewreck.org>
To:     Chengguang Xu <cgxu519@mykernel.net>
Cc:     ericvh <ericvh@gmail.com>, lucho <lucho@ionkov.net>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        v9fs-developer <v9fs-developer@lists.sourceforge.net>
Subject: Re: [V9fs-developer] [RFC PATCH] 9p: create writeback fid on shared
 mmap
Message-ID: <20201207112410.GA26628@nautica>
References: <20201205130904.518104-1-cgxu519@mykernel.net>
 <20201206091618.GA22629@nautica>
 <20201206205318.GA25257@nautica>
 <1763bcb5b8e.da1e98e51195.9022463261101254548@mykernel.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1763bcb5b8e.da1e98e51195.9022463261101254548@mykernel.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

Chengguang Xu wrote on Mon, Dec 07, 2020:
>  > , VM_MAYWRITE is set anytime we have a shared map where file has
>  > been opened read-write, which seems to be what you want with regards to
>  > protecting from mprotect calls.
>  > 
>  > How about simply changing check from WRITE to MAYWRITE?
> 
> It would be fine and based on the code in do_mmap(), it  seems we even don't
> need extra check here.  The condition (vma->vm_flags & VM_SHARED) will be enough.
> Am I missing something?

VM_MAYWRITE is unset if the file hasn't been open for writing (in which
case the mapping can't be mprotect()ed to writable map), so checking it
is a bit more efficient.

Anyway I'd like to obsolete the writeback fid uses now that fids have a
refcount (this usecase can be a simple refcount increase), in which case
efficiency is less of a problem, but we're not there yet...

Please resend with MAYWRITE if you want authorship and I'll try to take
some time to test incl. the mprotect usecase.

-- 
Dominique