Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201206144527.1670483-1-chanho61.park@samsung.com>
 <CGME20201207105410epcas2p3f9210689886172422d27870f25a79df3@epcas2p3.samsung.com>
 <20201207105359.GA4198@willie-the-truck> <001101d6cc90$3b491310$b1db3930$@samsung.com>
In-Reply-To: <001101d6cc90$3b491310$b1db3930$@samsung.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Mon, 7 Dec 2020 21:31:06 +0900
Message-ID: <CAM9d7chU0SP79cjuZOBg1Rhe2NYaxAOnKzdQ+XQ65fenTzak0A@mail.gmail.com>
Subject: Re: [PATCH] perf arm pmu: fix build error on MUSL libc
To:     Chanho Park <chanho61.park@samsung.com>
Cc:     Will Deacon <will@kernel.org>, Chanho Park <parkch98@gmail.com>,
        mathieu.poirier@linaro.org, suzuki.poulose@arm.com,
        coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        John Garry <john.garry@huawei.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Jiri Olsa <jolsa@redhat.com>, Khem Raj <raj.khem@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Chanho,

On Mon, Dec 7, 2020 at 8:58 PM Chanho Park <chanho61.park@samsung.com> wrote:
>
> Hi Will,
>
> > Looks like other files just include this unconditionally, but have a
> > comment explaining why. See util/branch.h and util/event.h. Maybe we
> > should do the same for util/pmu.h, which is already included here?
>
> I found below files which perf includes <linux/perf_event.h>. Instead of
> doing same for all, we'd better put this only for
> tools/include/uapi/linux/perf_event.h.

It's a copy of the kernel header, I'm not sure we want to add something there.

Thanks,
Namhyung