Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201205172207.GA4097@rlk> <20201207082300.38f5207f@canb.auug.org.au>
 <CANpmjNPifOwd9w34dSJhsvmP2sUkKa0ESPiJ7gj+gUDffhPO3A@mail.gmail.com>
In-Reply-To: <CANpmjNPifOwd9w34dSJhsvmP2sUkKa0ESPiJ7gj+gUDffhPO3A@mail.gmail.com>
From:   Marco Elver <elver@google.com>
Date:   Mon, 7 Dec 2020 15:52:07 +0100
Message-ID: <CANpmjNOWpa17L7mjhKdaFjWYfAzy12NjXUDtuPHpzm808QApRg@mail.gmail.com>
Subject: Re: [PATCH][next] arm64: fix the mm build error in mm/kfence/core.c
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Hui Su <sh_def@163.com>, Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        kasan-dev <kasan-dev@googlegroups.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, 6 Dec 2020 at 23:08, Marco Elver <elver@google.com> wrote:
> On Sun, 6 Dec 2020 at 22:23, Stephen Rothwell <sfr@canb.auug.org.au> wrot=
e:
[...]
> > > ../arch/arm64/include/asm/kfence.h:12:2: error: implicit declaration =
of
> > > function =E2=80=98set_memory_valid=E2=80=99 [-Werror=3Dimplicit-funct=
ion-declaration]
> > >    12 |  set_memory_valid(addr, 1, !protect);
> > >       |  ^~~~~~~~~~~~~~~~
> > > cc1: some warnings being treated as errors
> > >
> > > which introduced by commit d54febeba2ff ("kfence: use pt_regs to
> > > generate stack trace on faults").
> > >
> > > Signed-off-by: Hui Su <sh_def@163.com>
> > > ---
> > >  arch/arm64/include/asm/kfence.h | 1 +
> > >  1 file changed, 1 insertion(+)
>
> Thanks, but a patch for this is already in the -mm tree:
> https://lore.kernel.org/mm-commits/20201205011409.o9PNsRntR%25akpm@linux-=
foundation.org/
>
> Perhaps try the latest -next?

Although I notice that patch somehow was dropped from -mm, or maybe
I'm not looking hard enough?

> > > diff --git a/arch/arm64/include/asm/kfence.h b/arch/arm64/include/asm=
/kfence.h
> > > index 6c0afeeab635..4d73e34da59d 100644
> > > --- a/arch/arm64/include/asm/kfence.h
> > > +++ b/arch/arm64/include/asm/kfence.h
> > > @@ -4,6 +4,7 @@
> > >  #define __ASM_KFENCE_H
> > >
> > >  #include <asm/cacheflush.h>
> > > +#include <linux/set_memory.h>

I preferred the patch at

  https://lore.kernel.org/mm-commits/20201205011409.o9PNsRntR%25akpm@linux-=
foundation.org/

because it removed <asm/cacheflush.h> and only included <asm/set_memory.h>.

I hope the right patch finds its way into the queue. :-)

Thanks,
-- Marco

> > >  static inline bool arch_kfence_init_pool(void) { return true; }
> > >
> > > --
> > > 2.25.1
> >
> > Added to linux-next today.  I think it actually fixes patch "arm64,
> > kfence: enable KFENCE for ARM64" since that actually introduces the
> > set_memory_valid() call?
>
> The patch that moved the declaration was after the kfence patch, so
> it'd be the other way around:
> https://lkml.kernel.org/r/X8otwahnmGQGLpge@elver.google.com
>
> Thanks,
> -- Marco