Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2455326pxu; Mon, 7 Dec 2020 07:06:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJza6iUCQRLLnVY4pJeRbGe+RUnAmD68lnTDgNT5JAm2hcCTwx4gmeilcGJ9uOivp+S9v72U X-Received: by 2002:a17:906:22c7:: with SMTP id q7mr19237866eja.486.1607353605674; Mon, 07 Dec 2020 07:06:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607353605; cv=none; d=google.com; s=arc-20160816; b=ynpMZDfwwA0OBRHlAr/DGaHYODPOHZZPXgMtKG5v5PmA2GQg4DdIAqDcbFDBZlf+Zx o07b5CnbLyYMRIucGjIWJ7LWjzZ2yRm55zU7oAQkrAlEPdAQ40SdP8H7F16sPltSFHCT 9UUMWSLLvtNGi0uA/PZ5+eWd81QG4ggke57U83wse+KyEHCi1NrWV5SyZEXiN2E+evdF +LLAWQEagP2muRqlfktqW1YmVoDP5skczN390Gu7a5DTLDbJadA6Edd5+yKlxzXPrpAT 7NAOZHv+RrRjm+TkY76HUWk+Z31w1+8+NDzicfCdfDgNKlS67oVFC+NT9bne0/2nDlY/ uJow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=y5an9IpqP76fFEfITqq2IfrQNyjf5flDTbngmDsa0e0=; b=lLqTp/ttpgbJsBXvuPAlxVI7cDRt9pv8OWFNOYWHq1u4oQeMXz/PrEb0laiVvpO1hG djXuDurnMCQA4gQrjzR1S92SB62V5+thDOTjM/mTP3fxZPrlIoETaqQiwBTlh7pF9Mps pzjPY9itciMvIgF1rLNrgLZ2nYxqCAQn84GJ2pgIEzzxNIFztCjII11dscmhUoENmQed D7yeILKuhplM9mEi22/P8g2bvnbanYvMuNxAgvn31bE+VRfIT/SiUqAro1NVkheinhPH h6Uk/f6PznPAL83iQhpYoveexPseXxl1uJF+JnsXcufhYgwNplcoQ4ZscCjIvmxUQfmn danQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cloud.ionos.com header.s=google header.b=b0PNzOJC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ionos.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh18si6944256ejb.374.2020.12.07.07.06.04; Mon, 07 Dec 2020 07:06:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cloud.ionos.com header.s=google header.b=b0PNzOJC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ionos.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727060AbgLGPDd (ORCPT + 99 others); Mon, 7 Dec 2020 10:03:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726993AbgLGPDc (ORCPT ); Mon, 7 Dec 2020 10:03:32 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84F59C061749 for ; Mon, 7 Dec 2020 07:02:46 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id a16so19934417ejj.5 for ; Mon, 07 Dec 2020 07:02:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y5an9IpqP76fFEfITqq2IfrQNyjf5flDTbngmDsa0e0=; b=b0PNzOJCtcJg4O6coaXXwXy4BPnkF0lQigfsuS/Eux90pqnc8vuLYlLzaDrAzL4nw9 8ur8vzz9e0suu4AP8UKavHCm2e3dUXKMAQ+Tc51lywhBH29uIOzdjn8I/YAVi4lFtrYC 351Alkx/e3g3OBRpwWukHX2WrZtnbdW6tfqqwu6uU+f0XBu0m7lsi1zFFihHPapOT8wF Qo6gxm1kLhBuCb7sPzgKvRtuqZWVaQ5NgRQucwzG7mCRbB7yBBsgF6k5V9j39Kw8JrqL HLoOu8mwLaoKlDMHrzCuS69mqtOFzCDk8s/FocrZNzZeRjzGQSfybRgb8G9Zzzvi6swq ogOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y5an9IpqP76fFEfITqq2IfrQNyjf5flDTbngmDsa0e0=; b=ZmpjlG6zlLP09SEESlKcLwwz5RN5DUplcNwLFxEdtqqvJ4oX8juYmIkmHdGL5cZOGl y26kNcNV0nKEovkC9YH4CsOjogTek43z0QkR8P9KG6k3cifI5VzGEVcy+n1LaCjJiIQO 9snaH9d6HxmOoA2NTBTpsEDO0bykfmwkntskd+NTAGhLBZiFDTJskHHAr38rC4BCkqgl 8uZaXzOuoy2CHsxDaqyFABwlkNAbgb36XbEhvTEb68tl+fP0wiDl4ctN0VK1oDQXj3tt plr5A216Ncmir06Cykp2qjthHj4lMnkiRDRALE/DRG9B1SUHpqKw4twuhED3Gxuyn6ky +klA== X-Gm-Message-State: AOAM530Y5b346TMXiWeCWgPvUkOCHrX31a5Dg+yy/ilWfmL6dqhyVYjO LxJqfi22UJKeaAD0mwVhQvsu50TTmPKz0ynDNb6VpQ== X-Received: by 2002:a17:906:9452:: with SMTP id z18mr19468443ejx.389.1607353365047; Mon, 07 Dec 2020 07:02:45 -0800 (PST) MIME-Version: 1.0 References: <20201207145446.169978-1-colin.king@canonical.com> In-Reply-To: From: Jinpu Wang Date: Mon, 7 Dec 2020 16:02:34 +0100 Message-ID: Subject: Re: [PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink_name To: Jens Axboe , Colin King Cc: Danil Kipnis , Jason Gunthorpe , Bart Van Assche , linux-block , kernel-janitors@vger.kernel.org, open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 7, 2020 at 4:01 PM Jens Axboe wrote: > > On 12/7/20 7:54 AM, Colin King wrote: > > From: Colin Ian King > > > > Currently in the case where dev->blk_symlink_name fails to be allocates > > the error return path attempts to set an end-of-string character to > > the unallocated dev->blk_symlink_name causing a null pointer dereference > > error. Fix this by returning with an explicity ENOMEM error (which also > > is missing in the original code as was not initialized). > > Applied, thanks. Thanks Colin for the fix, and thanks Jens for taking care of this. Jack Wang