Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2455658pxu; Mon, 7 Dec 2020 07:07:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJxGcnYpO2TwC0+b8RQ4l/ivfJWg2XT6LdYEGsJCFUkvuFt7vLnoknnHtxcc5NuCSpqvy5WP X-Received: by 2002:aa7:cad2:: with SMTP id l18mr20241709edt.183.1607353627383; Mon, 07 Dec 2020 07:07:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607353627; cv=none; d=google.com; s=arc-20160816; b=0C975yiqFX2dMjneLzxjGy57bkiCc8RAMF2vXxn3LiLJu/trSqRovCsZEPu80wbnXp ymXZPFRiPmpM8GsFY0MBYfQ3vAI+QXEw2IaFlHGVrUCgUhOPiHi7FBjRx6ELHDwURGmh nGEqj6KTYutjz5fOCjpum6cs011WzM9rMA/cjcG4UNK3LWN/RPHwTq39O4C2MIlfwwum OtKoaSlPPLQLB9uJdkdb6ktU9ScCN/DNvP1I2zL+sOAc849cHSsmaD48yC9CamZSgr/R SRqIUnD137YyWEjwa9M+B4bESCQO23JOqmfnpRVmpHg3xT8yTE47C+AuVlsAzYeJISIP Qz+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=/bBHUQrvjqGZKDRY7e20G9Yb5H//5ix3nl8L9R+aPQo=; b=t/Z7+FRWlrjpEipSTA+6liScMuebopCBEr835V5f0VoNxQdY6oOLcfw1XR5j5Y7Mwm GYKL4bxjs3PkNPvTb0b9P/77n8yriuUsT59JWREr5Pnv6KmfnCSiDJF0XDJF6oZnNB/9 hxCbnkpYVdJPOJFIAccMmB6SNkwrYtkrMPDzDPHqzaXgRhtrXLxWDZxtvmjyAqpKNam9 BRhmVFDlXktdkiTwN/HmmsaWhf5Pgk8VUsCTaHH9Zm1gTpXIq00Plj83VYmSaqQyA/oU 6C8JaTw4EMUTVOeZnRFUmuM2tKgE14sf/HXYXXapNzyyXIX6l7zR0lYPO6GqzzabXbPp 8sMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=xOilBRuk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dx21si7470882ejb.657.2020.12.07.07.06.29; Mon, 07 Dec 2020 07:07:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=xOilBRuk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726142AbgLGPBq (ORCPT + 99 others); Mon, 7 Dec 2020 10:01:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725802AbgLGPBq (ORCPT ); Mon, 7 Dec 2020 10:01:46 -0500 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFF87C0617B0 for ; Mon, 7 Dec 2020 07:01:05 -0800 (PST) Received: by mail-il1-x130.google.com with SMTP id k8so12426084ilr.4 for ; Mon, 07 Dec 2020 07:01:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/bBHUQrvjqGZKDRY7e20G9Yb5H//5ix3nl8L9R+aPQo=; b=xOilBRukRNJyPZNFY5hLbRzb1Gs9g0uZTueG5TRB8tT3qA70yXcj9q5EDzp4VtcJ+n IeqTSkXAcWYtIh9nGk2VgDcaOPEppOJBfSjk+27iM1CvC8aPXqBkRUHetHAQqh1Y38Vk mmFAXo0XW4k5dHO+p4bVj8WaD8n0aKh1yCAHaRbKmz7qVXpHtuUiqpLis9dzAXq8YZ4K deUWEzNwle5vAbGOSYzZHA272ZVfaw9biImJpTUk5aDH6wDtLwp1NWLMDxRfVmtBmVMV jqG2jJO280JfegppbOYkop/MJh86fWHqkwYpQ1T0A9S3jFzsNC36Q0eQVAdsYaE0I9tO YLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/bBHUQrvjqGZKDRY7e20G9Yb5H//5ix3nl8L9R+aPQo=; b=A2f1GsKyQYYPQJLmv4FnTL7ZZGyoOFchkS+MThLAAWHiGWvviBH1xPydiZvF333aF0 7Mj7k/b42xMruaChm2+n+fwcfj2mFDEyp+A/ZUVEW3FvOQwjjjz8BViOV+IQr13HY53d v+Rc6Q4I5vj/9rXQt7AN8YU0MRFiI5cRd+OlDCKY8Cp1+MYwWE9JAgoocVok6hU8sycF 6HzuHngOtgtSzFT2cu0KZexqeibhOy8d6CoddqfEPdg8YB6DRmZDLVwUsTJ6sVnJtPMH cpAuaaa1sqSsEENpf+gKBt0mULSczN/I2uVg68jeZ0waSlMLJ+WEWrP6mp1DT9a6ts6U O60A== X-Gm-Message-State: AOAM533e6EtxCUQ5PuD1gKa2TF9fZRXJyDKfwQRfvbNknYK+9cy0ypLN cEtmrqiJ38bmrryNAs+cGc0G0lpA9zkVdQ== X-Received: by 2002:a92:6512:: with SMTP id z18mr22765471ilb.220.1607353264601; Mon, 07 Dec 2020 07:01:04 -0800 (PST) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id e18sm7455294ilm.77.2020.12.07.07.01.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Dec 2020 07:01:04 -0800 (PST) Subject: Re: [PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink_name To: Colin King , Danil Kipnis , Jack Wang , Jason Gunthorpe , Bart Van Assche , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201207145446.169978-1-colin.king@canonical.com> From: Jens Axboe Message-ID: Date: Mon, 7 Dec 2020 08:01:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201207145446.169978-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/20 7:54 AM, Colin King wrote: > From: Colin Ian King > > Currently in the case where dev->blk_symlink_name fails to be allocates > the error return path attempts to set an end-of-string character to > the unallocated dev->blk_symlink_name causing a null pointer dereference > error. Fix this by returning with an explicity ENOMEM error (which also > is missing in the original code as was not initialized). Applied, thanks. -- Jens Axboe