Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
CC:     Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] dpaa2-mac: Add a missing of_node_put after
 of_device_is_available
Thread-Topic: [PATCH] dpaa2-mac: Add a missing of_node_put after
 of_device_is_available
Thread-Index: AQHWy+Jn/I5MrlaSLUGeex0+/qP6F6nrvOKA
Date:   Mon, 7 Dec 2020 15:04:58 +0000
Message-ID: <20201207150457.arjw5geu2k6h2h2u@skbuf>
References: <20201206151339.44306-1-christophe.jaillet@wanadoo.fr>
In-Reply-To: <20201206151339.44306-1-christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <279721FE3A822941851595031090C82F@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f07a9238-741f-466a-b23d-08d89ac17737
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2020 15:04:59.0700
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cNX2IcB4SHNO/5C9Mvb+b+R003WEuIWpFcPxz9ArGYQhb5Q300n/KMUaAGCPQmM+uYzbRTw6vJAm6tN0vTHWCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2416
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Dec 06, 2020 at 04:13:39PM +0100, Christophe JAILLET wrote:
> Add an 'of_node_put()' call when a tested device node is not available.
>=20
> Fixes:94ae899b2096 ("dpaa2-mac: add PCS support through the Lynx module")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>


Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Thanks!

> ---
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/n=
et/ethernet/freescale/dpaa2/dpaa2-mac.c
> index 90cd243070d7..828c177df03d 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> @@ -269,6 +269,7 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,
> =20
>  	if (!of_device_is_available(node)) {
>  		netdev_err(mac->net_dev, "pcs-handle node not available\n");
> +		of_node_put(node);
>  		return -ENODEV;
>  	}
> =20
> --=20
> 2.27.0
> =