Received: by 2002:a05:6a10:f347:0:0:0:0 with SMTP id d7csp2481266pxu; Mon, 7 Dec 2020 07:41:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyyKg5u8lG81jNUP7WxmI9uw8QNE3zfbXKdCXXudE0A0vl9uh5JDyim4kxa7GSAMq/W79Cx X-Received: by 2002:a17:906:2b95:: with SMTP id m21mr19863731ejg.134.1607355707881; Mon, 07 Dec 2020 07:41:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1607355707; cv=none; d=google.com; s=arc-20160816; b=PDm/cZTbpzEvdXoDX4PMKeyBs+HNQ9SNe0KEbQ5BUKFBI28k6wcMRqQ/kOzl/J+t50 4NEbpXoJBzforhRhJW8JbiEUQ1EZ3A/QlkklvKmN20cG2FjpjqNcfB5IAhA09FOOpD5T eA8W5Uyn7Teuf4/1hGoM7icpBZ7fQEfO+TgXkEOHRVloSoRhTGVLC5w2CB7dH2z8/t/c loE6e0IhRJCbYwyTEiupVlAZno9HrYP9dAMgE4Kq8CFcpv5F2tuDy94cAgkclBqf3D37 uuoTq67bS2fyp8CLCS0B9JP8bfJ7j84FaaKWyrTBjp6JadTdxRevsG/wzM0LkYyHL6th DsTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=jaH2t71LlC39U8WALk3AP6Ffcuc5F2oI0FfO4aXs0TU=; b=IQ4bOLoWRE1h5D9gx4xEcfMsmuvJnIfBo/PTl6uVXLDzK9x/6ZyLYyZLXkDzdaFXsH EMHSxl68/rzklPcdQMOzW6YAb6JLD98/IPy4h1L5AmCy5E9u2ncysz3rwJJ/kMybRk9V iZY3rgV90l/xo+WNPN+rOj5FdninVVURJgMbDXp/vx5T/Q0uPOqiM2JGbKU30lxx4JuA GyGkxy3qLV6hRjiq8fdKk78mk7IvVE+OInCWQ6bq9gm85B6fzKD7gstkHeiEyPMY/QZz KRctmxWxL34/l45gqzYQdf7JMsFV67umXNWuve9cZ/CZZ9ux4ec1i3Kt9nOACQFL7Z0A mDxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi24si8738006edb.452.2020.12.07.07.41.23; Mon, 07 Dec 2020 07:41:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbgLGPhx (ORCPT + 99 others); Mon, 7 Dec 2020 10:37:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:38140 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgLGPhw (ORCPT ); Mon, 7 Dec 2020 10:37:52 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 07AE4233CF; Mon, 7 Dec 2020 15:37:10 +0000 (UTC) Date: Mon, 7 Dec 2020 10:37:08 -0500 From: Steven Rostedt To: Avri Altman Cc: Bean Huo , "alim.akhtar@samsung.com" , "asutoshd@codeaurora.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "stanley.chu@mediatek.com" , "beanhuo@micron.com" , "bvanassche@acm.org" , "tomas.winkler@intel.com" , "cang@codeaurora.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM Message-ID: <20201207103708.66897ef3@gandalf.local.home> In-Reply-To: References: <20201206164226.6595-1-huobean@gmail.com> <20201206164226.6595-4-huobean@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Dec 2020 07:57:27 +0000 Avri Altman wrote: > > > > TP_printk( > > - "%s: %s: HDR:%s, CDB:%s", > > + "%s: %s: HDR:%s, %s:%s", > > __get_str(str), __get_str(dev_name), > > __print_hex(__entry->hdr, sizeof(__entry->hdr)), > > + __get_str(tsf_type), > This breaks what current parsers expects. > Why str is not enough to distinguish between the command? Hopefully it shouldn't. Reading from user space should use the libtraceevent library, that reads the format files and extracts the raw data to find the fields. As long as the field exists, it should not break user space parsers. If it does, please let me know, and I'll gladly help change the user space code to use libtraceevent :-) -- Steve