Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Steven Rostedt' <rostedt@goodmis.org>,
        James Bottomley <James.Bottomley@HansenPartnership.com>
CC:     Ard Biesheuvel <ardb@kernel.org>,
        "laniel_francis@privacyrequired.com" 
        <laniel_francis@privacyrequired.com>,
        linux-efi <linux-efi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v1 07/12] efi: Replace strstarts() by
 str_has_prefix().
Thread-Topic: [RFC PATCH v1 07/12] efi: Replace strstarts() by
 str_has_prefix().
Thread-Index: AQHWzKs0kz/fG1FbOEiEJcYInMSfrqnr0Lsg
Date:   Mon, 7 Dec 2020 16:25:17 +0000
Message-ID: <70d98067245c4b4ebb411e68fb3162ef@AcuMS.aculab.com>
References: <20201204170319.20383-1-laniel_francis@privacyrequired.com>
        <20201204170319.20383-8-laniel_francis@privacyrequired.com>
        <CAMj1kXEQhT_LF5FDBO3-S7pBn55wG59bQUVr2q58A4FhqodY8Q@mail.gmail.com>
        <ab769a5188394cd3379cc627d14a0222050a1367.camel@HansenPartnership.com>
        <CAMj1kXFvCZKH-Bbvu-V5-GxcTun8yz98igeFxRc1tTswbttM0w@mail.gmail.com>
        <3161fc13d69c388b1f51f59c6ecea48dcd0a7856.camel@HansenPartnership.com>
        <CAMj1kXFZ1_05O=s37n7pJbFxRm_-hAVFHKqc6OtALfBMVZVYnQ@mail.gmail.com>
        <043040d9c092cedcab8bf88b0ec805616d3be44d.camel@HansenPartnership.com>
        <CAMj1kXHj0y9b+yGPDjyToFL6HYyyu23BuX3FMYmjGo5+6sgjUQ@mail.gmail.com>
        <8a169362defed5af16be78c5a11f4ff9f58da2a8.camel@HansenPartnership.com>
 <20201207101025.1d133a5d@gandalf.local.home>
In-Reply-To: <20201207101025.1d133a5d@gandalf.local.home>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Steven Rostedt
> Sent: 07 December 2020 15:10

> 
> On Sat, 05 Dec 2020 15:04:31 -0800
> James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> 
> > Well, I think the pattern
> >
> > if (strstarts(option, <string>)) {
> >    ...
> >    option += strlen(<same string>);
> >
> > is a bad one because one day <string> may get updated but not <same
> > string>.  And if <same string> is too far away in the code it might not
> > even show up in the diff, leading to reviewers not noticing either.  So
> > I think eliminating the pattern is a definite improvement.
> 
> And one of the reasons we created str_has_prefix() is because we fixed that
> exact bug, in a few places.
> 
> It was caused by a typo, where we had something like:
> 
> 	strstarts(option, "foo=") {
> 		option += strlen("foo");
> 
> and forgot the "=" part, and broke the rest of the logic.

And then someone else wonders whether the paint is the right colour.
Maybe the function should return the pointer to the character
after the prefix.

Suddenly you have a load of functions to pick from, none do
quite what you want - so you add yet another :-)

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)