Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 3pA6wnA0QtoVeJeppEcWL/im3P7+RJfVgxZYqp9sdCp0g4D4j1MquCkq67ckzhHNIqowDv5nRo
 3ipAAyk69GIWNNQAK3yTcsap4nmrupO1McuGOAocyrdDGw7dUaEaopxfYi7kfAgJ18O4UCv1Hd
 ei9Cb6VwPNL37zKRXad0r70OJqhIOLLR6wWhIPAhpTugCZkg7VXRNUZ7gDpYkddq9DsNP7yVo+
 ExTLxROiRpZeR77zpzJ09HDBlc/o4l8i+CohaBdZe0UdaICOaVh7SdTmT9+aMuJmohd63cUk/s
 ijo=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     Bean Huo <huobean@gmail.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate
 among CDB, OSF, and TM
Thread-Topic: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate
 among CDB, OSF, and TM
Thread-Index: AQHWy+7VP58/cpTtqkiyF4OIctzYqqnrRKJQgACBJQCAAA6aAA==
Date:   Mon, 7 Dec 2020 16:40:51 +0000
Message-ID: <DM6PR04MB6575CD229D3F6E1C1B30B11EFCCE0@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20201206164226.6595-1-huobean@gmail.com>
        <20201206164226.6595-4-huobean@gmail.com>
        <DM6PR04MB6575197B8626D3F91C9231C4FCCE0@DM6PR04MB6575.namprd04.prod.outlook.com>
 <20201207103708.66897ef3@gandalf.local.home>
In-Reply-To: <20201207103708.66897ef3@gandalf.local.home>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e05fb549-cf4c-44b2-ad63-08d89acedbff
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2020 16:40:51.6418
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ErkVLfSTGm2wCcjfkG+UGVym7ah8MZUxx1R28+/cokZCwXCLhsRtfWRy4wowxQjrxqLrnVymvkLFOTR+jFxdhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6574
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> On Mon, 7 Dec 2020 07:57:27 +0000
> Avri Altman <Avri.Altman@wdc.com> wrote:
>=20
> > >
> > >         TP_printk(
> > > -               "%s: %s: HDR:%s, CDB:%s",
> > > +               "%s: %s: HDR:%s, %s:%s",
> > >                 __get_str(str), __get_str(dev_name),
> > >                 __print_hex(__entry->hdr, sizeof(__entry->hdr)),
> > > +               __get_str(tsf_type),
> > This breaks what current parsers expects.
> > Why str is not enough to distinguish between the command?
>=20
> Hopefully it shouldn't. Reading from user space should use the
> libtraceevent library, that reads the format files and extracts the raw
> data to find the fields. As long as the field exists, it should not break
> user space parsers. If it does, please let me know, and I'll gladly help
> change the user space code to use libtraceevent :-)
Hi Steve,
Thanks. I wasn't aware of libtraceevent - is this a new thing?

We have a relatively sophisticated analysis platform that utilizes raw trac=
es,
Among which the upiu trace is the most important and informative.

This tool has evolved over the years, adding more and more parsers per need=
,
and the users are picking the appropriate parser per the trace they used.

We will surely be glad to adopt new tracing capabilities,
But we would prefer not to break anything.

Thanks,
Avri