Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ACPI: scan: Drop INT3396 from acpi_ignore_dep_ids[]
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
References: <12017158.VsPUki9SGr@kreacher>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <a78eed2a-4c33-7e1a-88df-d92e33c74e20@redhat.com>
Date:   Mon, 7 Dec 2020 17:57:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <12017158.VsPUki9SGr@kreacher>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 12/7/20 5:55 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> According to Hans, all device objects where the _HID returns
> "INT3396" also have a _CID returning "PNP0D80", so the former
> need not be present in acpi_ignore_dep_ids[] any more.
> 
> Link: https://lore.kernel.org/linux-acpi/52a2b98c-6bf3-760b-eca9-93cf05fb4877@redhat.com/
> Suggested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Thanks, patch looks good to me. FWIW:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
> 
> On top of https://patchwork.kernel.org/project/linux-acpi/patch/3849919.JfvvSOo2yN@kreacher/
> 
> ---
>  drivers/acpi/scan.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -751,7 +751,6 @@ static bool acpi_info_matches_ids(struct
>  
>  /* List of HIDs for which we ignore matching ACPI devices, when checking _DEP lists. */
>  static const char * const acpi_ignore_dep_ids[] = {
> -	"INT3396", /* Windows System Power Management Controller */
>  	"PNP0D80", /* Windows-compatible System Power Management Controller */
>  	NULL
>  };
> 
> 
>