Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Dec 2020 11:21:11 -0600
From:   Rob Herring <robh@kernel.org>
To:     Chris Ruehl <chris.ruehl@gtsys.com.hk>
Cc:     devicetree@vger.kernel.org, Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        Heiko Stuebner <heiko@sntech.de>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/2] devicetree: phy: rockchip-emmc add
 output-tapdelay-select
Message-ID: <20201207172039.GA463809@robh.at.kernel.org>
References: <20201202082507.3536-1-chris.ruehl@gtsys.com.hk>
 <20201202082507.3536-3-chris.ruehl@gtsys.com.hk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201202082507.3536-3-chris.ruehl@gtsys.com.hk>
Precedence: bulk

On Wed, Dec 02, 2020 at 04:25:07PM +0800, Chris Ruehl wrote:
> Update the rockchip-emmc-phy.txt and add the u32 property
> 'output-tapdelay-select'. This allow to set the otapdlysec register.
> 
> Tested with our customized rk3399 board to tune eMMC.
> 
> Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk>
> ---
>  Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> index 3e4d2d79a65d..00aa2d349e55 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt
> @@ -18,6 +18,9 @@ Optional properties:
>                          If not set, the default value of 50 will be applied.
>   - enable-strobe-pulldown: Enable internal pull-down for the strobe line.
>                             If not set, pull-down is not used.
> + - output-tapdelay-select: Specifies the phyctrl_otapdlysec register.
> +                           If not set, the register defaults to 0x4.
> +                           Maximum value 0xf.

Needs a vendor prefix.

>  
>  Example:
>  
> -- 
> 2.20.1
>