Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932192AbWHaNBt (ORCPT ); Thu, 31 Aug 2006 09:01:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932193AbWHaNBt (ORCPT ); Thu, 31 Aug 2006 09:01:49 -0400 Received: from ns.suse.de ([195.135.220.2]:3005 "EHLO mx1.suse.de") by vger.kernel.org with ESMTP id S932192AbWHaNBs (ORCPT ); Thu, 31 Aug 2006 09:01:48 -0400 Date: Thu, 31 Aug 2006 15:01:45 +0200 Message-ID: From: Takashi Iwai To: Pavel Machek Cc: Andrew Morton , kernel list , perex@suse.cz, alsa-devel@alsa-project.org, pshou@realtek.com.tw Subject: Re: sound/pci/hda/intel_hda: small cleanups In-Reply-To: <20060831123706.GC3923@elf.ucw.cz> References: <20060831123706.GC3923@elf.ucw.cz> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25) (eggplant) (+CVS-20060326) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1689 Lines: 63 At Thu, 31 Aug 2006 14:37:06 +0200, Pavel Machek wrote: > > @@ -271,8 +272,8 @@ struct azx_dev { > /* for sanity check of position buffer */ > unsigned int period_intr; > > - unsigned int opened: 1; > - unsigned int running: 1; > + unsigned int opened :1; > + unsigned int running :1; > }; > > /* CORB/RIRB */ > @@ -330,8 +331,8 @@ struct azx { > > /* flags */ > int position_fix; > - unsigned int initialized: 1; > - unsigned int single_cmd: 1; > + unsigned int initialized :1; > + unsigned int single_cmd :1; > }; Any official standard reference for bit-field expressions? > > /* driver types */ > @@ -642,14 +643,14 @@ static int azx_reset(struct azx *chip) > azx_writeb(chip, GCTL, azx_readb(chip, GCTL) | ICH6_GCTL_RESET); > > count = 50; > - while (! azx_readb(chip, GCTL) && --count) > + while (!azx_readb(chip, GCTL) && --count) > msleep(1); Hm, it looks rather like a personal preference. IMHO, it's harder to read without space... > @@ -999,8 +1000,7 @@ static struct snd_pcm_hardware azx_pcm_h > .info = (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_INTERLEAVED | > SNDRV_PCM_INFO_BLOCK_TRANSFER | > SNDRV_PCM_INFO_MMAP_VALID | > - SNDRV_PCM_INFO_PAUSE /*|*/ > - /*SNDRV_PCM_INFO_RESUME*/), > + SNDRV_PCM_INFO_PAUSE), The commented out item is there intentionally to indicate that the full-resume isn't implemented. I'll fix the volatile things separately. Thanks, Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/