Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 7 Dec 2020 19:23:12 +0100
From:   Greg KH <greg@kroah.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Daejun Park <daejun7.park@samsung.com>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "gregkh@google.com" <gregkh@google.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sang-yoon Oh <sangyoon.oh@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Adel Choi <adel.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>
Subject: Re: [PATCH v13 0/3] scsi: ufs: Add Host Performance Booster Support
Message-ID: <X85zEFduHeUr4YKR@kroah.com>
References: <CGME20201103044021epcms2p8f1556853fc23414442b9e958f20781ce@epcms2p8>
 <2038148563.21604378702426.JavaMail.epsvc@epcpadp3>
 <X85sxxgpdtFXiKsg@kroah.com>
 <20201207180655.GA30657@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201207180655.GA30657@infradead.org>
Precedence: bulk

On Mon, Dec 07, 2020 at 06:06:55PM +0000, Christoph Hellwig wrote:
> On Mon, Dec 07, 2020 at 06:56:23PM +0100, Greg KH wrote:
> > On Tue, Nov 03, 2020 at 01:40:21PM +0900, Daejun Park wrote:
> > > Changelog:
> > > 
> > > v12 -> v13
> > > 1. Cleanup codes by comments from Can Guo.
> > > 2. Add HPB related descriptor/flag/attributes in sysfs.
> > > 3. Change base commit from 5.10/scsi-queue to 5.11/scsi-queue.
> > 
> > What ever happened to this patchset?  Did it get merged into a scsi tree
> > for 5.11-rc1, or is there something still pending that needs to be done
> > on it to make it acceptable?
> 
> I think the problem here is not the code, but that the features is
> fundamentally a bad idea, and one that so far has not even shown
> to help real workloads vs the usual benchmarketing.

What "real workload" test can be run on this to help show if it is
useful or not?  These vendors seem to think it helps for some reason,
otherwise they wouldn't have added it to their silicon :)

Should they run fio?  If so, any hints on a config that would be good to
show any performance increases?

thanks,

greg k-h